Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.133.0 - releasestaging #11377

Merged
merged 137 commits into from
Dec 5, 2024
Merged

Release v1.133.0 - releasestaging #11377

merged 137 commits into from
Dec 5, 2024

Conversation

dwiley-akamai
Copy link
Contributor

Cloud Manager

Added:

  • Object Storage buckets to Support tickets dropdown (#11178)
  • Option to copy token on LKE details page (#11179)
  • Tooltip for 'Usable Storage' in Create/Resize Database table (#11223)
  • Ability to perform complex search queries on the Images landing page (#11233)
  • Credit Card Expired banner (#11240)
  • Product Families to Create Menu dropdown (#11260)
  • Accelerated compute plans in Linode/LKE create flows (#11287)
  • Docs link and region availability notice for Accelerated compute plans (#11363)

Changed:

  • Replace react-beautiful-dnd with dnd-kit library (#11127)
  • Linode details summary VPC IPv4 text to be copyable (#11172)
  • Replace Pagination page size autocomplete with simple select (#11203)
  • Replace Select component with Autocomplete in DBaaS (#11245)
  • Update types based on new VPU fields and added mock data (#11256)
  • Improve the status column on the Images landing page (#11257)
  • Improve Placement Groups UI during Linode migrations (#11261)
  • Update docs links on empty Database landing page (#11262)
  • Implement Dialogs/Drawers loading patterns (#11273)
  • Improve billing contact info display when Mask Sensitive Data setting is enabled (#11276)
  • Update and improve DBaaS Detail page styling and UI (#11282)
  • Add IPV6 tooltip to read-only host in DBaaS summary (#11291)
  • DBaaS Resize GA: Enable Downsizing (horizontal and vertical), enable 'Shared' tab, update node presentation (#11311)
  • Update DBaaS Access Controls copy, placeholders, and button text (#11371)
  • Adjust network_in values for distributed plans (#11313)

Fixed:

  • Broken firewall rules table (#11127)
  • Table component styling issue for noOverflow property (#11127)
  • Alignment for Backup Label in Add-ons Panel (#11160)
  • Kubernetes details page UI issues (#11217)
  • Radio size prop not affecting the radio button's dimensions (#11242)
  • Storybook docgen (#11264)
  • DBaaS: summary read-only host field is blank (#11265)
  • DBaaS: landing paginator disappears when pageSize is less than the number of instances (#11275)
  • Incorrect Account Maintenance X-Filter (#11277)
  • Storybook optimizeDeps config to improve cold start (#11278)
  • Table and Chart Legend Spacing (#11294)
  • Content shifting on Linode Details summary graphs (#11301)
  • CORS toggle incorrectly appearing for Object Storage bucket objects (#11355)
  • LinodeCreate OS Panel fetching region with -1 on page load (#11356)
  • Lack of uniform spacing between resource link columns in empty state landing pages (#11213)
  • Convert Object Storage bucket sizes from GiB to GB in the frontend (#11293)

Removed:

  • Migrate CircleProgress from manager to ui package (#11214)
  • Move ClickAwayListener from manager to ui package (#11267)
  • TooltipIcon component (migrated to ui package) (#11269)
  • Move Checkbox from manager to ui package (#11279)
  • Move H1Header from manager to ui package (#11283)
  • TextField component and convertToKebabCase utility function (migrated to ui package) (#11290)
  • Toggle component and ToggleOn and ToggleOff icons (migrated to ui package) (#11296)
  • Migrate EditableText from manager to ui package (#11308)
  • Autocomplete, List, and ListItem components (migrated to ui package) (#11314)
  • Move Accordion from manager to ui package (#11316)
  • Recently added camelCase rule (#11330)
  • Migrate FormControlLabel from manager to ui package (#11353)
  • Move Chip from manager to ui package (#11266)

Tech Stories:

  • Update PULL_REQUEST_TEMPLATE (#11219, #11236)
  • Optimize Events Polling following changes from incident (#11263)
  • Add documentation for form validation best practices (#11298)
  • Update developer docs on unit testing user events (#11221)
  • Refactor components to use clamp from @linode/ui rather than ramda (#11306)
  • Update yup from 0.32.9 to 1.4.0 (#11324)
  • Further improvements to PR template author checklist sections (#11325)
  • Bump recharts to ^2.14.1 (#11358)
  • Change Pendo sanitized URL path string (#11361)
  • Replace one-off hardcoded color values with color tokens pt3 (#11241)
  • Adjust linter rules for common PR feedback points (#11258)
  • Adjust linter rules for naming convention (#11337)

Tests:

  • Add Cypress test for Account Maintenance CSV downloads (#11168)
  • Mock disable OBJ Gen 2 flags for existing OBJ Cypress tests (#11191)
  • Fix DBaaS resize tests that fail on first attempt and succeed on second (#11238)
  • Add Cypress tests to verify ACLP UI's handling of API errors (#11239)
  • Unskip Placement Group landing page navigation test (#11272)
  • Fix Linode migration test failure caused by region label conflicts (#11274)
  • Add Cypress test for restricted user Image Empty landing page (#11281)
  • Fix StackScript update test failure triggered by recent deprecation (#11292)
  • Fix test failure in linode-storage.spec.ts (#11304)
  • Fix machine-image-upload.spec.ts test failures (#11319)
  • Add tests for accelerated plans in plan-selection.spec.ts (#11323)
  • Add new assertions for linode backup Cypress tests (#11326)
  • Add test to create a mock accelerated Linode (#11327)
  • Fix DBaaS unit test flake (#11332)
  • Add unit test cases for DialogTitle component (#11340)
  • Add unit test cases for EntityHeader component (#11222)
  • Add unit test cases for CopyableTextField component (#11268)
  • Add unit test cases for DocsLink component (#11336)

Upcoming Features:

  • Replace LineGraph with AreaChart and add DataSet type in CloudPulseLineGraph component, add connectNulls, dotRadius, showDot, xAxisTickCount property and ChartVariant interface in AreaChart.ts (#11204)
  • Configure max limit on CloudPulse resource selection component (#11252)
  • Add Create Alert Button, Add Name, Description, Severity components to the Create Alert Form (#11255)
  • Add feature flag and hook for LKE-E enablement (#11259)
  • Add and update kubernetes queries for LKE-E beta endpoints (#11302)
  • Handle JWE token limit of 250 in ACLP UI (#11309)
  • Modify generate12HoursTicks method in AreaChart utils.ts, remove breakpoint condition in MetricsDisplay.tsx, modify legendHeight and xAxisTickCount in CloudPulseLineGraph.tsx (#11317)
  • Add new PAT ‘Monitor’ scope for CloudPulse (#11318)
  • Add Cluster Type section to Create Cluster flow for LKE-E (#11322)
  • Update Region Select for LKE-Enterprise (#11348)
  • Update Regions/S3 Hostnames interface to match new design guidelines with
    improved visualization of multiple storage regions (#11355)
  • Remove Properties tab visibility for users without Gen2 capabilities and fix duplicate bucket display issue (#11355)
  • Add new routes for IAM, feature flag and menu item (#11310)
  • Mock data and query for new IAM permission API (#11146)
  • Mock data and query for new IAM account API (#11181)
  • Add ResourceMultiSelect component for CloudPulse alerting (#11331)
  • Service, Engine Option, Region components to CloudPulse Create Alert form (#11286)

harsh-akamai and others added 30 commits November 7, 2024 12:54
… dropdown (#11178)

* feat: [M3-8528] - Include Object Storage in Support Tickets

* query change

* Added changeset: Include Object Storage buckets in Support tickets dropdown

* added link support for object storage

* removed redundant query

* query updation and restructuring request payload

* Added changeset
* refactor: [M3-8646] – Migrate `Divider` to `ui` package

* Added changeset: Migrate Divider to ui package

* migrating all  imports

* removing redundant hook imports

* updated the import for omittedProps
* initial clean up

* save progress

* add changeset

* fix type error

* feedback @mjac0bs

* a few more small fixes

* a few more small fixes

---------

Co-authored-by: Banks Nussman <[email protected]>
* migrate stack, update organization for divider/icon button

* Added changeset: `Stack` component to `ui` package
…age and update imports (#11174)

* Move Notice to UI package and update imports

* Add test imports

* Add renderWithTheme and other changes to make tests pass

* Fix broken icon imports

* Added changeset: Move `Notice` and `Tooltip` components to UI package

* Feedback @dwiley-akamai: consolidate imports and rename icon exports
…py Object. (#11172)

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object.

* Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object.

* Update changeset description

Co-authored-by: Purvesh Makode <[email protected]>

* remove optional chaining

* change Text from "Subnets" to "Subnet"

* remove extra borderTop

* refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object

* Add descriptive variable name

---------

Co-authored-by: Purvesh Makode <[email protected]>
* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table

* feat: [UIE-8193] - Tooltip context for small screens
…er `fireEvent` (#11221)

* Update 08-testing.md for userEvent

* Fix typo

* Address feedback; also further clean up linting issues the doc

* Fix a bad test that was not following good practices

* Added changeset: Update developer docs on unit testing user events
* feat: [M3-8665] - add option to copy token in LKE details page.

* Added changeset: option to copy token in LKE details page

* Change the "Copy Token" button to use asynchronous functionality

* remove extra styling

* refactor: [M3-8665] - add option to copy token in LKE details page.

* Change cypress test for LKE update spec
* Make updates discussed to PR template during retro

* Add changeset
* Move RadioGroup to ui package

* Added changeset: Move `RadioGroup` from `manager` to `ui` package
…ry changes (#11238)

* Set DBaaS resize test mock database instance platform to `'rdbms-legacy'`

* Added changeset: Fix DBaaS resize tests that fail on first attempt and succeed on second
…ss tests (#11191)

* update existing obj cypress tests to mock obj gen 2 flags as disabled

* update access-key spec

* Added changeset: Mock disable OBJ Gen 2 flags for existing OBJ Cypress tests
…tate Landing Pages (#11213)

* Fix spacing for empty state landing pages

* Fix styling for mobile and empty youtube resource sections

* Add changeset
* initial work

* make overriding contains filter shape more generic

* make things more generic

* allow underscore in seaches

* allow `:` in searches

* only disable retries if the user is searching

* add changeset

* add changeset

* use `errorText` prop @hana-akamai

* add comment to summarize what is filterable

---------

Co-authored-by: Banks Nussman <[email protected]>
* Migrate radio to ui package

* Add vitest imports in Radio tests

* Fix radio icons imports

* Add `vite-plugin-svgr` plugin to UI package

* Added changeset: Move `Radio` from `manager` to `ui` package

* Reordering imports

* Temporarily import `FormControlLabel` from MUI

* Remove typecast from plugin configuration in all places

* Fix: avoid imports from @linode/ui in @linode/ui

* Remove todo comments
* test: [M3-8550] - Add unit tests for EntityHeader component

* Added changeset: unit test cases for EntityHeader component
…omponent (#11252)

* upcoming: [DI-20934] - Configurable Max limit on resource selection component

* upcoming: [DI-20934] - PR comments

* upcoming: [DI-20934] - Small fix

* upcoming: [DI-20934] - Added sorting of resources

* upcoming: [DI-20934] - PR comments

* upcoming: [DI-20934] - PR comments

* upcoming: [DI-20934] - small fix

* upcoming: [DI-20934] - Added changeset

* upcoming: [DI-21867] - Resources selection tag limit

* upcoming: [DI-20934] - PR comments on UT and Changeset
…ete (#11245)

* change: [UIE-8245] - DBaaS: replace Select with Autocomplete

* change: [UIE-8245] - DBaaS: replace Select with Autocomplete (Settings Tab)

* Added changeset: Replace Select component with Autocomplete

* change: [UIE-8245] - review fix, show default engine
…API errors (#11239)

* Add Cypress tests to verify ACLP UI's handling of API errors

* Update packages/manager/.changeset/pr-11239-tests-1731305530868.md
* Remove ts-docgen optimization

* Added changeset: Storybook docgen
* Move Button to UI package

* Added changeset: Migrate `Button` component and styled variants

* Tweaks: fix cannibalistic imports, tests and more

* PR feedback @coliu-akamai: consolidate imports, fix comment
…or tokens pt3 (#11241)

* Replace one-off hardcoded color values with color tokens pt3

* Replace #c9c7c7 with theme.tokens.color.Neutrals[40]

* Replace #606469 with theme.tokens.color.Neutrals[70]

* Replace #555 with theme.tokens.color.Neutrals[80]

* Replace #c9cacb with theme.tokens.color.Neutrals[40] or equivalent

* Added changeset: Replace one-off hardcoded color values with color tokens pt3

* Replace '#9ea4ae' with theme.tokens.color.Neutrals[50]

* Replace `#cdd0d5` with `theme.tokens.color.Neutrals[30]`

* Replace `#ccc` with `theme.tokens.color.Neutrals[40]`

* Replace `#222` with `theme.tokens.color.Neutrals.Black`

* Replace `#f4f4f4` with `theme.tokens.color.Neutrals[5]` or equivalent

* Update changeset file

* Remove color instances from Divider component
…age (#11267)

* Move `ClickAwayListener` to `ui` package

* Added changeset: Move `ClickAwayListener` from `manager` to `ui` package

* Added changeset: Move `ClickAwayListener` from `manager` to `ui` package
zaenab-akamai and others added 11 commits December 4, 2024 09:21
… dimensions (#11242)

* Customizing radio button sizes

* Added a sample

* Reverted sample

* Updated sizes for medium and small radio buttons

* Added changeset

* Wrapped radio icons in SvgIcon & added font sizes to themes/light.ts

* fixes

* linting fix
* bump recharts to ^2.14.1

* Added changeset: Bump recharts to ^2.14.1
…elerated plans (#11363)

* update link + add region availability banner

* Added changeset: Docs link and region availability notice for Accelerated compute plans

* update plan-selection tests due (new banner added)
…XR request (#11361)

* Change sanitized url path string to match UXR request

* Added changeset: Change Pendo sanitized URL path string
* Fix regression with AppBar

* feedback @mjac0bs
## Description 📝
LKE-Enterprise will not be available in all regions. It will be available in limited DCs initially, then expanded to all core DCs. We want to clearly communicate to users why they cannot select the same DCs for LKE-E as we offer for LKE. 

## Changes  🔄
- Filter region select by the `Kubernetes Enterprise` capability if LKE-E is selected & show tooltip

## How to test 🧪

### Prerequisites

(How to setup test environment)

- Ensure you have the LKE-E customer tag on your account (see Project Tracker)
- Point to the development environment

### Verification steps

(How to verify changes)

- [ ] Go to http://localhost:3000/kubernetes/create
- [ ] When LKE standard cluster type is selected, all regions with the Kubernetes capability are displayed.
- [ ] When the LKE enterprise cluster type is selected, regions are filtered display only those with the Kubernetes Enterprise capability.
  - [ ] A tooltip is displayed next to the region select that explains the reason for the limited list.
- [ ] When the lkeEnterprise feature is disabled, no region tooltip is visible.
- [ ] Confirm test coverage passes

```
yarn cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts"
```
* feat: [M3-8953] - OBJ Gen2 Updates

* Add changeset

* fix duplicate buckets landing page, may rework

* Update e2e tests

* Remove redundant beforeEach

* Small adjustment to request

* fix access keys e2e test

* Fix bucket-create-gen2.spec.ts failing tests @linode/frontend-sdet

* E2E review updates @cliu-akamai @AzureLatte

* Fix issue where properties content was overriding SSL for non-gen2 capability users @coliu-akamai

* Remove CORS from object drawers @bnussman-akamai

* Update packages/manager/.changeset/pr-11355-upcoming-features-1733237339445.md

Co-authored-by: Dajahi Wiley <[email protected]>

* Update packages/manager/.changeset/pr-11355-upcoming-features-1733237339445.md

Co-authored-by: Dajahi Wiley <[email protected]>

* Remove double copy icon @dwiley-akamai

* Add changesets

* Update packages/manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyTable/HostNameTableCell.tsx

Co-authored-by: Banks Nussman <[email protected]>

* Pluralize the regions

* Fix E2E based in pluralize

* Fix unit tests

* Fix e2e from removing toggle

---------

Co-authored-by: Jaalah Ramos <[email protected]>
Co-authored-by: Connie Liu <[email protected]>
Co-authored-by: Dajahi Wiley <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
…#11293)

* fix: [M3-8740] - Convert Object Storage size from GiB to GB in frontend

* Added changeset: Convert Object Storage bucket sizes from `GiB` to `GB` in the frontend

* refactor: [M3-8740] - Convert Object Storage size from GiB to GB in frontend

* Change comment description
…x defaultDB for legacy instances (#11371)

* feat: [UIE-8269], [UIE-8290] - DBaaS: Access Controls text update, fix defaultDB for legacy instances

* feat: [UIE-8269], [UIE-8290] - refactoring

* feat: [UIE-8269], [UIE-8290] - fix e2e test

* Added changeset: DBaaS : Updated copy, placeholders, and button text in Access Controls, fixed default DB value for legacy instances
@dwiley-akamai dwiley-akamai added the Release → Staging Pre-Release: Release → Staging label Dec 5, 2024
@dwiley-akamai dwiley-akamai self-assigned this Dec 5, 2024
@dwiley-akamai dwiley-akamai requested review from a team as code owners December 5, 2024 17:50
@dwiley-akamai dwiley-akamai requested review from AzureLatte, mjac0bs and coliu-akamai and removed request for a team December 5, 2024 17:50
Copy link

github-actions bot commented Dec 5, 2024

Coverage Report:
Base Coverage: 87.46%
Current Coverage: 86.85%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My machine/browser can't handle this diff very well, but confirming versioning and dogfooding outcome ✅

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing465 Passing2 Skipped109m 34s

Details

Failing Tests
SpecTest
clone-linode.spec.tsclone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@dwiley-akamai
Copy link
Contributor Author

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing ✅ Passing ↪️ Skipped 🕐 Duration
1 Failing 465 Passing 2 Skipped 109m 34s

Details

Failing Tests
Spec Test
clone-linode.spec.ts clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Confirmed that this was a flake and not an actual issue

@dwiley-akamai dwiley-akamai merged commit 99c2d6c into staging Dec 5, 2024
24 of 25 checks passed
Copy link

cypress bot commented Dec 5, 2024

Cloud Manager E2E    Run #6926

Run Properties:  status check passed Passed #6926  •  git commit 99c2d6ceef: Merge pull request #11377 from linode/release-v1.133.0
Project Cloud Manager E2E
Branch Review staging
Run status status check passed Passed #6926
Run duration 29m 19s
Commit git commit 99c2d6ceef: Merge pull request #11377 from linode/release-v1.133.0
Committer Dajahi Wiley
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release → Staging Pre-Release: Release → Staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.