feat: [UIE-8131] - IAM RBAC: Routes, Menu, Feature Flag #11310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaleksee-akamai
requested review from
bnussman-akamai and
cpathipa
and removed request for
a team
aaleksee-akamai
force-pushed
the
UIE-8131-iam-rbac-routes-menu
branch
2 times, most recently
from
3fb6fc4
to
7b7680c
Compare
|
Coverage Report: ✅ |
aaleksee-akamai
force-pushed
the
UIE-8131-iam-rbac-routes-menu
branch
2 times, most recently
from
4ca42f7
to
703a31b
Compare
| ); | ||
| }; | ||
|
|
||
| export default IdentityAccessManagement; |
There was a problem hiding this comment.
This exports IdentityAccessManagement already. Let's just keep the named export and remove this default export
Suggested change
| export default IdentityAccessManagement; |
| <Switch> | ||
| <Route component={UserDetails} path={`${path}/users/:username/`} /> | ||
| <Redirect exact from={path} to={`${path}/users`} /> | ||
| <Route component={IAMLanding} path={`${path}`} /> |
There was a problem hiding this comment.
Suggested change
| <Route component={IAMLanding} path={`${path}`} /> | |
| <Route component={IAMLanding} path={path} /> |
Comment on lines
17
to
19
| type CombinedProps = RouteComponentProps; | ||
|
|
||
| export const IdentityAccessManagement: React.FC<CombinedProps> = (props) => { |
There was a problem hiding this comment.
We can express this in a cleaner way. We aren't combining any types to we don't need a type called CombinedProps. We also don't need to use React.FC.
Suggested change
| type CombinedProps = RouteComponentProps; | |
| export const IdentityAccessManagement: React.FC<CombinedProps> = (props) => { | |
| export const IdentityAccessManagement = (props: RouteComponentProps) => { |
| ); | ||
| }); | ||
|
|
||
| export default IdentityAccessManagementLanding; |
There was a problem hiding this comment.
For consistency, can we just remove this default export and export IdentityAccessManagementLanding
aaleksee-akamai
force-pushed
the
UIE-8131-iam-rbac-routes-menu
branch
from
703a31b
to
b189765
Compare
|
@bnussman-akamai , thanks, I've updated this PR |
bnussman-akamai
approved these changes
Dec 2, 2024
Cloud Manager UI test results🔺 4 failing tests on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts" |
||||||||||||||||||||||||||
cpathipa
approved these changes
Dec 3, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 30m 49s |
| Commit |
|
| Committer | aaleksee-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
465
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
IAM RBAC - all routes, menu, feature flag
Changes 🔄
Target release date 🗓️
Dec 10, 2024 (dev)
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.|
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅