Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-8259] dbaas landing paginator disappears when pageSize is less than the number of instances #11275

Merged

Conversation

smans-akamai
Copy link
Contributor

Description 📝

DbaaS landing page table paginator disappears when the pageSize is less than the number of instances retrieved from the backend. This prevents users from being able to view the additional instances that would be displayed on the following pages.

Changes 🔄

  • DBaaS Landing page now leverages the results property instead of the length of the number of database instances retrieved from a single page via the backend response. The results property provides the total number of instances.

Target release date 🗓️

12/10/2024

Preview 📷

Before After
before-fix after-fix

How to test 🧪

Prerequisites

  • Have the ability to access the database landing page and create new databases

Reproduction steps

  • Create a greater number of databases than the default or set pageSize determined by your preferences.
  • ie. Create 29 databases if your pageSize is 25.
  • Observe that the paginator is no longer visible

Verification steps

  • Access the databaseLanding page with the databases created in the reproduction steps
  • Observe that the paginator is now visible and does not get hidden when you adjust the pageSize.

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@smans-akamai smans-akamai requested a review from a team as a code owner November 18, 2024 20:18
@smans-akamai smans-akamai requested review from dwiley-akamai and harsh-akamai and removed request for a team November 18, 2024 20:18
@smans-akamai smans-akamai force-pushed the UIE-8263-dbaas-landing-paginator-fix branch from 939211d to 412400d Compare November 18, 2024 20:21
Copy link

github-actions bot commented Nov 18, 2024

Coverage Report:
Base Coverage: 86.9%
Current Coverage: 86.9%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing451 Passing2 Skipped85m 16s

Details

Failing Tests
SpecTest
migrate-linode.spec.tsMigrate linodes » shows DC-specific pricing information when migrating linodes to similarly priced DCs

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts"

@bnussman-akamai bnussman-akamai added Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service labels Nov 18, 2024
@cpathipa cpathipa requested review from cpathipa and removed request for harsh-akamai November 18, 2024 21:15
@cpathipa cpathipa added Approved Multiple approvals and ready to merge! Add'tl Approval Needed Waiting on another approval! and removed Approved Multiple approvals and ready to merge! labels Nov 19, 2024
@cpathipa
Copy link
Contributor

Confirming failed e2e test is not relevent to this.
image

@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 20, 2024
@cpathipa cpathipa merged commit 8aa1545 into linode:develop Nov 20, 2024
22 of 23 checks passed
Copy link

cypress bot commented Nov 20, 2024

Cloud Manager E2E    Run #6852

Run Properties:  status check failed Failed #6852  •  git commit 8aa154583b: fix: [UIE-8259] dbaas landing paginator disappears when pageSize is less than th...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6852
Run duration 27m 17s
Commit git commit 8aa154583b: fix: [UIE-8259] dbaas landing paginator disappears when pageSize is less than th...
Committer smans-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 452
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts • 1 failed test

View Output Video

Test Artifacts
object storage end-to-end tests > can create and delete object storage buckets Screenshots Video
Flakiness  cypress/e2e/core/linodes/resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by increasing size when offline: cold migration Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants