Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [UIE-8268] dbaas summary add tooltip for ipv6 to read-only host for new db clusters #11291

Conversation

smans-akamai
Copy link
Contributor

Description 📝

Add tooltip for IPV6 to read-only host field on summary page for new db clusters. This tooltip will only appear if there is a host and it is not N/A.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Added tooltip for IPV6 to read-only host field on summary page for new db clusters.
  • The tooltip will only appear if there is a host and it is not N/A.

Target release date 🗓️

12/10/2024

Preview 📷

Before After
readonly-before readonly-after-2

How to test 🧪

Prerequisites

  • Have a new database so you can access it's summary page.
  • The database must have a populated read-only host field, must not be N/A

Verification steps

  • Access the new database summary
  • View that the populated read-only host field has a thumbnail with the ipv6 text

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@smans-akamai smans-akamai requested a review from a team as a code owner November 19, 2024 20:36
@smans-akamai smans-akamai requested review from bnussman-akamai and hkhalil-akamai and removed request for a team November 19, 2024 20:36
@smans-akamai smans-akamai force-pushed the UIE-8268-add-ipv6-tooltip-to-readonly-host branch from b0ea5af to bbd84eb Compare November 19, 2024 20:45
@smans-akamai smans-akamai force-pushed the UIE-8268-add-ipv6-tooltip-to-readonly-host branch from bbd84eb to c263162 Compare November 19, 2024 21:41
@mjac0bs mjac0bs added the DBaaS Relates to Database as a Service label Nov 19, 2024
@mjac0bs mjac0bs requested a review from cpathipa November 19, 2024 21:44
Copy link

Coverage Report:
Base Coverage: 86.88%
Current Coverage: 86.88%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing452 Passing2 Skipped96m 34s

Details

Failing Tests
SpecTest
update-stackscripts.spec.tsUpdate stackscripts » updates a StackScript

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/stackscripts/update-stackscripts.spec.ts"

@hkhalil-akamai hkhalil-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 19, 2024
@cpathipa cpathipa removed the request for review from bnussman-akamai November 20, 2024 01:41
@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 20, 2024
@cpathipa cpathipa merged commit 84de904 into linode:develop Nov 20, 2024
22 of 23 checks passed
Copy link

cypress bot commented Nov 20, 2024

Cloud Manager E2E    Run #6854

Run Properties:  status check failed Failed #6854  •  git commit 84de904462: change: [UIE-8268] dbaas summary add tooltip for ipv6 to read-only host for new ...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6854
Run duration 31m 12s
Commit git commit 84de904462: change: [UIE-8268] dbaas summary add tooltip for ipv6 to read-only host for new ...
Committer smans-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 452
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  switch-linode-state.spec.ts • 2 flaky tests

View Output Video

Test Artifacts
switch linode state > reboots a linode from landing page Screenshots Video
switch linode state > reboots a linode from details page Screenshots Video
Flakiness  linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Boots a config Screenshots Video
Flakiness  clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  linode-storage.spec.ts • 1 flaky test

View Output Video

Test Artifacts
linode storage tab > try to delete in use disk Screenshots Video
Flakiness  update-linode-labels.spec.ts • 1 flaky test

View Output Video

Test Artifacts
update linode label > updates a linode label from the "Settings" tab Screenshots Video

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants