Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [DI-21119] - Handle jwe token limit in ACLP UI and Bug fix for resources component #11309

Merged

Conversation

ankita-akamai
Copy link
Contributor

@ankita-akamai ankita-akamai commented Nov 22, 2024

Description 📝

Handled jwe token limit in ACLP UI and Bug fix for resources component.

Changes 🔄

List any change(s) relevant to the reviewer.

  • JWE token will only be created for selected resources/database clusters. It was earlier created for all the available resources of selected service type.
  • Resources/Database clusters autocomplete has a bug fix -
    When these three are equal => 1. available resources/clusters 2. selected resources/clusters 3. max resource selection limit, select/deselect all will work as expected. Earlier, in this edge case, deselect all got disabled after maximum resources selection.

Target release date 🗓️

2-Dec-2024

Preview 📷

Before After
image image

How to test 🧪

Verification steps

(How to verify changes)

  • Navigate to monitor tab.
  • Select all the filters.
  • Open networks tab, see the token call fired, observe the payload passed, it has selected resources/clusters' ids.

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai ankita-akamai marked this pull request as ready for review November 22, 2024 13:29
@ankita-akamai ankita-akamai requested a review from a team as a code owner November 22, 2024 13:29
@ankita-akamai ankita-akamai requested review from pmakode-akamai and harsh-akamai and removed request for a team November 22, 2024 13:29
Copy link

github-actions bot commented Nov 25, 2024

Coverage Report:
Base Coverage: 86.93%
Current Coverage: 86.93%

@ankita-akamai
Copy link
Contributor Author

@bnussman-akamai is there any additional feedback for this pr or it is good for approval?

Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! A small nit for the changeset

@ankita-akamai
Copy link
Contributor Author

Changes look good! A small nit for the changeset

@harsh-akamai done!

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing451 Passing2 Skipped101m 50s

Details

Failing Tests
SpecTest
machine-image-upload.spec.tsmachine image » uploads machine image, mock finish event
machine-image-upload.spec.tsmachine image » uploads machine image, mock upload canceled failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock failed to decompress failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock expired upload event

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts"

@bnussman-akamai bnussman-akamai merged commit 4d59953 into linode:develop Nov 27, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants