-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-21119] - Handle jwe token limit in ACLP UI and Bug fix for resources component #11309
upcoming: [DI-21119] - Handle jwe token limit in ACLP UI and Bug fix for resources component #11309
Conversation
Coverage Report: ✅ |
@bnussman-akamai is there any additional feedback for this pr or it is good for approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! A small nit for the changeset
packages/manager/.changeset/pr-11309-upcoming-features-1732282296647.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Harsh Shankar Rao <[email protected]>
@harsh-akamai done! |
Cloud Manager UI test results🔺 4 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts" |
Description 📝
Handled jwe token limit in ACLP UI and Bug fix for resources component.
Changes 🔄
List any change(s) relevant to the reviewer.
When these three are equal => 1. available resources/clusters 2. selected resources/clusters 3. max resource selection limit, select/deselect all will work as expected. Earlier, in this edge case, deselect all got disabled after maximum resources selection.
Target release date 🗓️
2-Dec-2024
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅