-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8908] - Optimize Events Polling following changes from incident #11263
refactor: [M3-8908] - Optimize Events Polling following changes from incident #11263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid PR - did not notice any regression with any of the eventing scenarios I tried:
- event polling ✅
- events page (with and without events) ✅
- events page infinite scrolling ✅
- linode activity ✅
@bnussman-akamai only thing is you'll need is a changeset
Coverage Report: ✅ |
Cloud Manager UI test results🎉 453 passing tests on test run #6 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified:
- Events landing page in general
- Mocking 0 events displays no results and the 'You don't have any events on your account' copy
- Mocking 0 events in the last 7 days but older events past 7 days displays those older events
- Events infinitely scroll
- The activity feed on a Linode details page shows recent and past 7 days events for that Linode
- Polling works - the progress bar for in-progress events updates every few seconds that polling happens
- Events are marked as seen when the notification center is viewed
Cloud Manager E2E Run #6850
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6850
|
Run duration | 26m 39s |
Commit |
426be755c6: refactor: [M3-8908] - Optimize Events Polling following changes from incident (#...
|
Committer | Banks Nussman |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
452
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/stackscripts/update-stackscripts.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Update stackscripts > updates a StackScript |
Screenshots
Video
|
Description 📝
Changes 🔄
useInitialEventsQuery
hook and moves all logic intouseEventsInfiniteQuery
, similar to the implementation before change: [M3-8450] - Lower Events historical data fetching to 7 days #10899useEventsInfiniteQuery
that ensures the first fetch always limited to a 7 day window 📆Preview 📷
Note
No UI changes expected
How to test 🧪
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅