Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8908] - Optimize Events Polling following changes from incident #11263

Conversation

bnussman-akamai
Copy link
Member

Description 📝

Changes 🔄

Preview 📷

Note

No UI changes expected

How to test 🧪

  • Test the Events landing page in general
    • Test on an account with 0 events
    • Test infinite scrolling
    • Test on an account with 0 events within the last 7 days, but events past that 7 day period
  • Test the activity feed on a Linode details page
  • Verify events polling works as expected
    • For example, if you shutdown a Linode, you should see the percentage for that every update every few seconds
  • Verify events get marked as seen as expected

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the React Query Relating to the transition to use React Query label Nov 14, 2024
@bnussman-akamai bnussman-akamai self-assigned this Nov 14, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review November 14, 2024 21:43
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner November 14, 2024 21:43
@bnussman-akamai bnussman-akamai requested review from mjac0bs, pmakode-akamai, jaalah-akamai and abailly-akamai and removed request for a team November 14, 2024 21:43
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid PR - did not notice any regression with any of the eventing scenarios I tried:

  • event polling ✅
  • events page (with and without events) ✅
  • events page infinite scrolling ✅
  • linode activity ✅

@bnussman-akamai only thing is you'll need is a changeset

Copy link

github-actions bot commented Nov 19, 2024

Coverage Report:
Base Coverage: 86.88%
Current Coverage: 86.88%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 453 passing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing453 Passing2 Skipped83m 41s

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified:

  • Events landing page in general
    • Mocking 0 events displays no results and the 'You don't have any events on your account' copy
    • Mocking 0 events in the last 7 days but older events past 7 days displays those older events
    • Events infinitely scroll
  • The activity feed on a Linode details page shows recent and past 7 days events for that Linode
  • Polling works - the progress bar for in-progress events updates every few seconds that polling happens
  • Events are marked as seen when the notification center is viewed

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Nov 19, 2024
@bnussman-akamai bnussman-akamai merged commit 426be75 into linode:develop Nov 19, 2024
23 checks passed
Copy link

cypress bot commented Nov 19, 2024

Cloud Manager E2E    Run #6850

Run Properties:  status check failed Failed #6850  •  git commit 426be755c6: refactor: [M3-8908] - Optimize Events Polling following changes from incident (#...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6850
Run duration 26m 39s
Commit git commit 426be755c6: refactor: [M3-8908] - Optimize Events Polling following changes from incident (#...
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 452
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/stackscripts/update-stackscripts.spec.ts • 1 failed test

View Output Video

Test Artifacts
Update stackscripts > updates a StackScript Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! React Query Relating to the transition to use React Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants