Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8833] - Update API types and mock data for VPU plans #11256

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 13, 2024

Description 📝

Updates api types and mocks data so that Accelerated plans show up when using MSW

Accelerated plans will be hidden behind an account capability - we currently do not plan to use a feature flag

Changes 🔄

  • introduce new account and region capability
  • update types and fix type errors
  • add Accelerated mock data so that tab shows up

Target release date 🗓️

12/10

Preview 📷

image

How to test 🧪

  • Confirm API types match API spec (see linked ticket)
  • when using MSW, confirm tab for accelerated devices shows up (Went a bit into M3-8834 to get the mocked data to show up; M3-8834 will continue to make the plans panel look like the figma). NOTE: there is a bug/weird thing happening, where when you first select an accelerated plan, the panel will switch to the 'Premium CPU' tab. This happens if any column is after the 'Premium CPU' tab, not just the 'accelerated' tab... looking into this, but might move to m3-8834 + opening up this PR for review as well

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai self-assigned this Nov 13, 2024
@coliu-akamai coliu-akamai changed the title upcoming: [M3-8833] - Update types and mock data for VPU plans feat: [M3-8833] - Update types and mock data for VPU plans Nov 14, 2024
@coliu-akamai coliu-akamai changed the title feat: [M3-8833] - Update types and mock data for VPU plans feat: [M3-8833] - Update API types and mock data for VPU plans Nov 15, 2024
@coliu-akamai coliu-akamai marked this pull request as ready for review November 15, 2024 16:53
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 15, 2024 16:53
@coliu-akamai coliu-akamai requested review from bnussman-akamai and abailly-akamai and removed request for a team November 15, 2024 16:53
@@ -110,7 +110,7 @@ export const resizeLinode = (linodeId: number, data: ResizeLinodePayload) =>
* automatically appended to the root user's authorized keys file.
*/
export const rebuildLinode = (linodeId: number, data: RebuildRequest) =>
Request<{}>(
Request<Linode>(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(updated this type since this request does return a Linode)
https://techdocs.akamai.com/linode-api/reference/post-rebuild-linode-instance

Copy link

github-actions bot commented Nov 15, 2024

Coverage Report:
Base Coverage: 87.32%
Current Coverage: 87.32%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 445 passing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing445 Passing2 Skipped85m 44s

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 18, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 18, 2024
@coliu-akamai coliu-akamai merged commit f73af31 into linode:develop Nov 18, 2024
23 checks passed
Copy link

cypress bot commented Nov 18, 2024

Cloud Manager E2E    Run #6839

Run Properties:  status check failed Failed #6839  •  git commit f73af31068: feat: [M3-8833] - Update API types and mock data for VPU plans (#11256)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6839
Run duration 28m 23s
Commit git commit f73af31068: feat: [M3-8833] - Update API types and mock data for VPU plans (#11256)
Committer Connie Liu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 451
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/migrate-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
Migrate linodes > shows DC-specific pricing information when migrating linodes to similarly priced DCs Screenshots Video
Flakiness  parentChild/account-switching.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Parent/Child account switching > From Parent to Child > can switch from Parent account user to Proxy account user from Billing page Screenshots Video
Flakiness  objectStorageGen2/bucket-object-gen2.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Object Storage Gen2 bucket object tests > can check Object details drawer with E0 endpoint type Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants