-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8741] - Add linter rules for common pr feedback points #11258
feat: [M3-8741] - Add linter rules for common pr feedback points #11258
Conversation
5b627a3
to
e93ddb4
Compare
e93ddb4
to
6a7ada3
Compare
As per the ticket, I'm unsure if we should really remove the I haven't removed it yet, but I’m wondering if we should keep it or not. |
Coverage Report: ✅ |
"no-console": "error", | ||
"no-undef-init": "off", | ||
"radix": "error", | ||
"@typescript-eslint/no-unused-vars": "off", | ||
"@typescript-eslint/no-inferrable-types": "off", | ||
"@typescript-eslint/no-namespace": "warn", | ||
"@typescript-eslint/camelcase": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the existing camelCase rule from packages (as it was not working), and added a new one for the necessary packages
Cloud Manager UI test results🎉 453 passing tests on test run #6 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ CamelCase rule is working
✅ Warns when there's any
✅ Checks for self-closing tags when necessary
✅ Builds properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no-explicit-any
is enforced ✅
camelcase
warning is enforced ✅
self-closing-comp
is enforced for components and HTML tags ✅
No issues building ✅
All checks pass ✅
I would be in favor of keeping it; I would prefer not to get warnings in cases like that. |
Cloud Manager E2E Run #6858
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6858
|
Run duration | 30m 53s |
Commit |
654d24c4ad: feat: [M3-8741] - Add linter rules for common pr feedback points (#11258)
|
Committer | Purvesh Makode |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
3
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
451
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/linode-storage.spec.ts • 3 failed tests
Test | Artifacts | |
---|---|---|
linode storage tab > delete disk |
Screenshots
Video
|
|
linode storage tab > add a disk |
Screenshots
Video
|
|
linode storage tab > resize disk |
Screenshots
Video
|
Description 📝
Looking through recent contributions from external teams, there are some rules we can consider adding to reduce common feedback points.
note: I didn't find a way to "Enforce boolean values are not used as types (as per the ticket)" because using true/false as types is valid TS behavior.
Changes 🔄
api-v4
,manager
,validation
, andui
packageTarget release date 🗓️
N/A
How to test 🧪
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅