Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8836] - Add test to create a mock accelerated Linode #11327

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 25, 2024

Description 📝

Creates a mock accelerated linode. Adds a todo to eventually switch to a full e2e test (when accelerated plans are not as limited - M3-8946)

Target release date 🗓️

12/10

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/create-linode.spec.ts"

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai self-assigned this Nov 25, 2024
@coliu-akamai coliu-akamai marked this pull request as ready for review November 25, 2024 21:51
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 25, 2024 21:51
@coliu-akamai coliu-akamai requested review from cliu-akamai and removed request for a team November 25, 2024 21:51
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 25, 2024 21:56
@coliu-akamai coliu-akamai requested review from bnussman-akamai and harsh-akamai and removed request for a team November 25, 2024 21:56
Comment on lines -37 to -41
import {
mockCreateLinode,
mockGetLinodeDisks,
mockGetLinodeVolumes,
} from 'support/intercepts/linodes';
Copy link
Contributor Author

@coliu-akamai coliu-akamai Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just consolidated multiple imports from the same file)

Copy link

github-actions bot commented Nov 25, 2024

Coverage Report:
Base Coverage: 86.93%
Current Coverage: 86.98%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 456 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing456 Passing2 Skipped106m 5s

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Nov 26, 2024
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @coliu-akamai! Thanks!

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 26, 2024
@coliu-akamai coliu-akamai merged commit d495fd7 into linode:develop Nov 27, 2024
23 checks passed
Copy link

cypress bot commented Nov 27, 2024

Cloud Manager E2E    Run #6894

Run Properties:  status check passed Passed #6894  •  git commit d495fd7edb: test: [M3-8836] - Add test to create a mock accelerated Linode (#11327)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6894
Run duration 29m 15s
Commit git commit d495fd7edb: test: [M3-8836] - Add test to create a mock accelerated Linode (#11327)
Committer Connie Liu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 462
View all changes introduced in this branch ↗︎

@coliu-akamai coliu-akamai deleted the m3-8836 branch November 27, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants