feat: [M3-8947] - Improve linter rules for naming convention #11337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
requested review from
hana-akamai and
cpathipa
and removed request for
a team
Cloud Manager UI test results🎉 455 passing tests on test run #3 ↗︎
|
jaalah-akamai
approved these changes
Nov 27, 2024
cpathipa
requested review from
hana-akamai
and removed request for
hana-akamai
cpathipa
approved these changes
Dec 2, 2024
pmakode-akamai
added
Approved
Cloud Manager E2E
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 33m 24s |
| Commit |
|
| Committer | Purvesh Makode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
461
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/rebuild-linode.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| rebuild linode > rebuilds a linode from Account StackScript |
Screenshots
Video
|
|
linodes/rebuild-linode.spec.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| rebuild linode > rebuilds a linode from Image |
Screenshots
Video
|
|
| rebuild linode > rebuilds a linode from Community StackScript |
Screenshots
Video
|
|
linodes/clone-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
linodes/update-linode-labels.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| update linode label > updates a linode label from the "Settings" tab |
Screenshots
Video
|
|
account/service-transfer.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Account service transfers > can initiate and cancel a service transfer |
Screenshots
Video
|
|
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Follow up to the PR: #11330
Previously added camelcase rule in
api-v4andmanagerwas causing thousands of warnings due to APIv4 property names in our codebase.This PR Improves linter rules for naming convention - enforces rules for variables, functions, typeLike (
class,enum,interface,typeAlias,typeParameter), and parameters, without the need to create any custom rules.Changes 🔄
api-v4andmanagerpackage) for:Target release date 🗓️
N/A
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅