Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [UIE-8253] - DBaaS GA: UI update, bug fix #11282

Merged

Conversation

mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Nov 19, 2024

Description 📝

DBaaS GA: UI update, bug fix.

Changes 🔄

  • Database Settings: Changed the button style from primary to outlined for Suspend Cluster, Manage Access Controls, Reset Root Password, and Delete Cluster
  • Database Settings > Maintenance: Updated UI
  • Version Upgrade > Popup dialog: Updated the text to display the correct instance name
  • Database Summary: Updated the UI to prevent text wrapping for the "Engine" value
  • Database Summary > Connection Details: Added 'Database name' field
  • Database Landing Page: Disabled all features except resume and delete when database is either in suspended or in suspending (state)
  • Database Settings refactoring

Target release date 🗓️

12/10/24

Preview 📷

Before After
Screenshot 2024-11-19 at 1 03 49 PM Screenshot 2024-11-19 at 1 03 57 PM
Screenshot 2024-11-19 at 1 04 33 PM Screenshot 2024-11-19 at 1 05 01 PM
Screenshot 2024-11-19 at 1 05 26 PM Screenshot 2024-11-19 at 1 05 35 PM
Screenshot 2024-11-19 at 1 08 44 PM Screenshot 2024-11-19 at 1 08 55 PM

How to test 🧪

Prerequisites

Verification steps

  • Database Landing Page : choose the database cluster and click 'Suspend' in action menu. Verify that when the cluster is suspended, only the 'Resume' and 'Delete' actions are available for this cluster.
  • Navigate to the Database Settings tab to see updated UI
  • Navigate to the Database Summary tab to see updated UI and new field in Connection Details section
  • Navigate to the Database Setting > Version Upgrade > Popup dialog: Confirm that the text displays the correct instance name.

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner November 19, 2024 12:19
@mpolotsk-akamai mpolotsk-akamai requested review from mjac0bs and bnussman-akamai and removed request for a team November 19, 2024 12:19
…ed UI for Maintenance and Summary tabs, added 'Database name' in Connection Details, fix text in Version Upgrade popup, disabled actions for suspended/suspending clusters
Copy link

github-actions bot commented Nov 19, 2024

Coverage Report:
Base Coverage: 86.88%
Current Coverage: 86.88%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing451 Passing2 Skipped90m 4s

Details

Failing Tests
SpecTest
migrate-linode.spec.tsMigrate linodes » shows DC-specific pricing information when migrating linodes to similarly priced DCs

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts"

@mpolotsk-akamai mpolotsk-akamai self-assigned this Nov 19, 2024
@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! DBaaS Relates to Database as a Service labels Nov 19, 2024
@cpathipa cpathipa self-requested a review November 19, 2024 14:50
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirming on the verification steps.

@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 19, 2024
@cpathipa cpathipa merged commit efc7b22 into linode:develop Nov 19, 2024
22 of 23 checks passed
@mjac0bs mjac0bs removed their request for review November 19, 2024 16:23
Copy link

cypress bot commented Nov 19, 2024

Cloud Manager E2E    Run #6845

Run Properties:  status check passed Passed #6845  •  git commit efc7b22264: change: [UIE-8253] - DBaaS GA: UI update, bug fix (#11282)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6845
Run duration 26m 46s
Commit git commit efc7b22264: change: [UIE-8253] - DBaaS GA: UI update, bug fix (#11282)
Committer mpolotsk-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 453
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants