Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [UIE-8228] - DBaaS Resize GA: Enable Downsizing, update node presentation #11311

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

mpolotsk-akamai
Copy link
Contributor

Description 📝

DBaaS Resize GA: Enable Downsizing (horizontal and vertical) and enable 'Shared' tab for resizing 2N cluster. Updated node presentation.

Changes 🔄

Database Resize:

  • Enable Downsizing (horizontal and vertical)
  • Enable the 'Shared' tab for resizing 2N cluster
  • Enable 'Current Plan' for selection

Updated node presentation in the 'Database Summary' and 'Database Resize' tabs.

Target release date 🗓️

12/10/24

Preview 📷

Before After
Screenshot 2024-11-22 at 4 00 42 PM Screenshot 2024-11-22 at 4 01 06 PM
Screenshot 2024-11-22 at 4 05 31 PM Screenshot 2024-11-22 at 4 05 40 PM
Screenshot 2024-11-22 at 4 06 04 PM Screenshot 2024-11-22 at 4 06 13 PM

How to test 🧪

Prerequisites

  • dbaasV2 feature flag set to GA
  • choose a new database

Verification steps

  • Select the new database.
  • Navigate to the Database Resize tab.
  • Database Cluster is available for downsizing (both horizontal and vertical)
  • Shared Tab is enabled for 2 Nodes Cluster
  • Database Resize > Current configurations: the Nodes presentation is updated
  • Summary tab: the Nodes presentation is updated

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner November 22, 2024 15:08
@mpolotsk-akamai mpolotsk-akamai requested review from carrillo-erik and abailly-akamai and removed request for a team November 22, 2024 15:08
@mpolotsk-akamai mpolotsk-akamai self-assigned this Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Coverage Report:
Base Coverage: 86.95%
Current Coverage: 86.95%

@cpathipa cpathipa requested review from cpathipa and removed request for abailly-akamai November 22, 2024 19:14
@mjac0bs mjac0bs added the DBaaS Relates to Database as a Service label Nov 22, 2024
@bnussman-akamai
Copy link
Member

Can you resolve the conflicts? We just fixed some DBaaS test flake in #11332 and are hoping to keep it not flakey

@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-8228-Enable-downsizing branch from 9c0ec30 to 866cc01 Compare November 27, 2024 09:33
@mpolotsk-akamai
Copy link
Contributor Author

Can you resolve the conflicts? We just fixed some DBaaS test flake in #11332 and are hoping to keep it not flakey

@bnussman-akamai , resolved

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality and code changes look good to me. Confirming the verification steps.

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Dec 2, 2024
@cpathipa cpathipa requested review from bnussman-akamai and removed request for carrillo-erik December 2, 2024 14:47
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing453 Passing2 Skipped111m 56s

Details

Failing Tests
SpecTest
service-transfer.spec.tsAccount service transfers » can initiate and cancel a service transfer
clone-linode.spec.tsclone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/account/service-transfer.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts"

@cpathipa
Copy link
Contributor

cpathipa commented Dec 2, 2024

Confirming failed clone-linode.spec.ts passed in local and I think service-transfer is not relevant to this PR.

@cpathipa cpathipa merged commit b39d3e7 into linode:develop Dec 2, 2024
22 of 23 checks passed
Copy link

cypress bot commented Dec 2, 2024

Cloud Manager E2E    Run #6903

Run Properties:  status check failed Failed #6903  •  git commit b39d3e7986: change: [UIE-8228] - DBaaS Resize GA: Enable Downsizing, update node presentatio...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6903
Run duration 30m 49s
Commit git commit b39d3e7986: change: [UIE-8228] - DBaaS Resize GA: Enable Downsizing, update node presentatio...
Committer mpolotsk-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 461
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/rebuild-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
Flakiness  linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  firewalls/migrate-linode-with-firewall.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Migrate Linode With Firewall > migrates linode with firewall - real data Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants