fix: [M3-8924] - Storybook optimizeDeps config to improve cold start
#11278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
mjac0bs,
bnussman-akamai and
hkhalil-akamai
and removed request for
a team
abailly-akamai
force-pushed
the
M3-8924
branch
from
db06635 to
56b6301
Compare
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 453 passing tests on test run #3 ↗︎
|
mjac0bs
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
I haven't personally experienced the Storybook issues described in this PR description, likely because I've only run Storybook locally on a few PRs while this migration has been happening.
I did verify that on this branch, yarn storybook loaded Storybook as expected (slowly, but no more slowly than it normally loads for me) and I did not see any error output.
bnussman-akamai
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Similar to @mjac0bs, I haven't been experience any issues like the ones described. I haven't been running storybook often. Maybe 2 or 3 times per week.
Happy to support this if it helps the workflow of the team!
bnussman-akamai
added
Approved
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR attempts to config Storybook's
optimizeDepsto stabilize the developer experience during the@linode/uimigration. Often time devs are getting dev build errors with cache validation when using storybook locally after components have been migrated, and especially while switching branches.. Clearing cache manually does not always achieve a clean slate, but I have found this config to help and not add friction or performance degradation.Changes 🔄
optimizeDepsconfig to storybookHow to test 🧪
Verification steps
yarn storybookAs an Author, before moving this PR from Draft to Open, I confirmed ✅