feat: [M3-8915] - Improve UI for billing contact info when sensitive data is masked #11276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
force-pushed
the
M3-8915-improve-masked-billing-contact-info-ui
branch
from
380720e to
55d86aa
Compare
mjac0bs
force-pushed
the
M3-8915-improve-masked-billing-contact-info-ui
branch
from
796bd32 to
ceaad55
Compare
…tive Data setting is enabled
mjac0bs
requested review from
AzureLatte,
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
mjac0bs
commented
Nov 20, 2024
| @@ -38,20 +44,7 @@ interface Props { | |||
| zip: string; | |||
| } | |||
|
|
|||
| const StyledTypography = styled(Typography)(({ theme }) => ({ | |||
There was a problem hiding this comment.
Changes here were just to:
- move this styling to a separate .styles file
- use a named, rather than default, export
There was a problem hiding this comment.
Changes in this file were to support the use of the CDS 2.0 visibility icon in this tooltip, rather than MUI's.
| }) | ||
| ); | ||
|
|
||
| // eslint-disable-next-line sonarjs/no-identical-functions |
There was a problem hiding this comment.
These are two different icons that need the same styling.
|
Coverage Report: ✅ |
dwiley-akamai
approved these changes
Nov 20, 2024
hkhalil-akamai
approved these changes
Nov 20, 2024
hkhalil-akamai
added
Approved
|
@hkhalil-akamai Good idea for user efficiency. Done in c8b2735. Screen.Recording.2024-11-20.at.12.46.34.PM.mov |
Cloud Manager UI test results🎉 454 passing tests on test run #7 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 43s |
| Commit |
|
| Committer | Mariah Jacobs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
454
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Recently, we added a Mask Sensitive Data enhancement that allows the user to obscure data, including contact information.
This is functioning as expected on the Account > Billing page, where Billing Contact Info fields are masked when the feature is enabled, but the UI presentation of this can be further improved.
Note
UX has approved these changes.
Changes 🔄
ContactInformation: moved styled components toContactInformation.styles.tsand removed the default exportTarget release date 🗓️
12/10
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅