-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8903] - Improve Image Status Column #11257
feat: [M3-8903] - Improve Image Status Column #11257
Conversation
Cloud Manager UI test results🎉 445 passing tests on test run #3 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good!✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and test coverage looked clean; image actions showed the expected statuses*. This looks much nicer!
*Out of scope, existing API behavior: Do we know why the API returns a 0% percent_complete once the image has finished creating? It makes for a strange minute of seemingly backward progress in the UI before we finally get the 'Available' image.
image-create-api-percent-complete.mov
@mjac0bs Thanks for reminding me of that bug! Just posted in the Image Service Gen2 channel about it |
Description 📝
Available
instead of overwritten value ofReady
so that Cloud Manager is more similar to the API ✏️Preview 📷
Made Status Column consider region statuses
Screen.Recording.2024-11-13.at.5.02.14.PM.mov
Screen.Recording.2024-11-13.at.4.53.31.PM.mov
Improved Image Upload Failure
How to test 🧪
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅