test: [M3-8934] - Fix test failure in linode-storage.spec.ts
#11304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, clean up and doc improvements
…` util" This reverts commit ab37757.
jdamore-linode
requested review from
AzureLatte
and removed request for
a team
jdamore-linode
requested review from
carrillo-erik and
abailly-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Nov 21, 2024
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 454 passing tests on test run #2 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 42s |
| Commit |
|
| Committer | jdamore-linode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
454
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This fixes a persistent failure in
linode-storage.spec.ts. I couldn't track down the specific change but it seems like the API now rejects requests to add/modify disks when the desired size is very small (in our case, it was 1MB).This also increases the timeout we use when creating Linodes. A lot of our Linode e2e tests don't actually use this constant, so hoping to follow up (most likely in a separate PR) with additional changes to address this recent flakiness of our other Linode e2e tests.
Changes 🔄
LINODE_CREATE_TIMEOUTfrom 3 minutes to 4 minutesTarget release date 🗓️
N/A
How to test 🧪
(Pending)
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅