upcoming: [M3-8847] - Update Region Select for LKE-Enterprise #11348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hana-akamai Merged #11322 so feel free to rebase this branch on develop. 👍🏼 |
hana-akamai
force-pushed
the
M3-8847-update-region-select-lke-e
branch
from
29cca16 to
315fc20
Compare
hana-akamai
commented
Dec 2, 2024
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
hana-akamai
requested review from
AzureLatte,
carrillo-erik,
cpathipa and
mjac0bs
and removed request for
a team
|
Coverage Report: ✅ |
mjac0bs
reviewed
Dec 3, 2024
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Show resolved
Hide resolved
bnussman-akamai
approved these changes
Dec 4, 2024
Cloud Manager UI test results🎉 465 passing tests on test run #7 ↗︎
|
mjac0bs
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 16s |
| Commit |
|
| Committer | Hana Xu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
465
|
| View all changes introduced in this branch ↗︎ | |
|
@hana-akamai @jaalah fyi, this pr has altered the region select autocomplete in an unexpected manner causing the region select width to shrink in both, linode create page as shown below, and also in our monitor tab.. |
| @@ -121,7 +121,7 @@ export const RegionSelect = < | |||
| }} | |||
| sx={(theme) => ({ | |||
| [theme.breakpoints.up('md')]: { | |||
| width: '416px', | |||
| maxWidth: tooltipText ? '458px' : '416px', | |||
There was a problem hiding this comment.
This is the culprit here... putting out a PR
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
LKE-Enterprise will not be available in all regions. It will be available in limited DCs initially, then expanded to all core DCs. We want to clearly communicate to users why they cannot select the same DCs for LKE-E as we offer for LKE.
Changes 🔄
Kubernetes Enterprisecapability if LKE-E is selected & show tooltipPreview 📷
Screen.Recording.2024-12-03.at.5.52.35.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅