-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8639] - Move Accordion
to linode/ui
package
#11316
Merged
hasyed-akamai
merged 4 commits into
linode:develop
from
hasyed-akamai:M3-8639-move-accordion-from-manager-to-ui-package
Nov 26, 2024
Merged
refactor: [M3-8639] - Move Accordion
to linode/ui
package
#11316
hasyed-akamai
merged 4 commits into
linode:develop
from
hasyed-akamai:M3-8639-move-accordion-from-manager-to-ui-package
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasyed-akamai
force-pushed
the
M3-8639-move-accordion-from-manager-to-ui-package
branch
from
November 25, 2024 08:36
63a40fe
to
0d551bd
Compare
Co-authored-by: Harsh Shankar Rao <[email protected]>
hasyed-akamai
requested review from
mjac0bs and
hana-akamai
and removed request for
a team
November 25, 2024 12:32
Cloud Manager UI test results🔺 4 failing tests on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts" |
bnussman-akamai
approved these changes
Nov 25, 2024
hasyed-akamai
added
Add'tl Approval Needed
Waiting on another approval!
and removed
Ready for Review
labels
Nov 25, 2024
mjac0bs
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No UI regressions, tests pass as expected, Storybook looks good. 🚢
mjac0bs
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Nov 25, 2024
hana-akamai
approved these changes
Nov 25, 2024
Cloud Manager E2E Run #6883
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6883
|
Run duration | 30m 08s |
Commit |
cf84d85adb: refactor: [M3-8639] - Move `Accordion` to `linode/ui` package (#11316)
|
Committer | hasyed-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
2
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
453
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/rebuild-linode.spec.ts • 2 failed tests
Test | Artifacts | |
---|---|---|
rebuild linode > rebuilds a linode from Community StackScript |
Screenshots
Video
|
|
rebuild linode > rebuilds a linode from Account StackScript |
Screenshots
Video
|
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Migrate
Accordion
tolinode/ui
package.Target release date 🗓️
N/A
How to test 🧪
Check all that apply