Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8639] - Move Accordion to linode/ui package #11316

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

Migrate Accordion to linode/ui package.

Target release date 🗓️

N/A

How to test 🧪

  • All tests should pass
  • There should be no adverse impacts observed in Cloud

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai self-assigned this Nov 25, 2024
@hasyed-akamai hasyed-akamai force-pushed the M3-8639-move-accordion-from-manager-to-ui-package branch from 63a40fe to 0d551bd Compare November 25, 2024 08:36
@hasyed-akamai hasyed-akamai marked this pull request as ready for review November 25, 2024 12:32
@hasyed-akamai hasyed-akamai requested a review from a team as a code owner November 25, 2024 12:32
@hasyed-akamai hasyed-akamai requested review from mjac0bs and hana-akamai and removed request for a team November 25, 2024 12:32
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing451 Passing2 Skipped112m 46s

Details

Failing Tests
SpecTest
machine-image-upload.spec.tsmachine image » uploads machine image, mock finish event
machine-image-upload.spec.tsmachine image » uploads machine image, mock upload canceled failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock failed to decompress failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock expired upload event

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts"

@hasyed-akamai hasyed-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Nov 25, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No UI regressions, tests pass as expected, Storybook looks good. 🚢

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 25, 2024
@hasyed-akamai hasyed-akamai merged commit cf84d85 into linode:develop Nov 26, 2024
22 of 23 checks passed
Copy link

cypress bot commented Nov 26, 2024

Cloud Manager E2E    Run #6883

Run Properties:  status check failed Failed #6883  •  git commit cf84d85adb: refactor: [M3-8639] - Move `Accordion` to `linode/ui` package (#11316)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6883
Run duration 30m 08s
Commit git commit cf84d85adb: refactor: [M3-8639] - Move `Accordion` to `linode/ui` package (#11316)
Committer hasyed-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 453
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/rebuild-linode.spec.ts • 2 failed tests

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
rebuild linode > rebuilds a linode from Account StackScript Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants