fix: [M3-8904] - Fix Storybook docgen #11264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
requested review from
dwiley-akamai and
abailly-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Nov 14, 2024
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 445 passing tests on test run #2 ↗︎
|
abailly-akamai
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
I can't even load storybook anymore but that's unrelated to this change. The cache is messed up (we gonna need to configure optimizeDeps).
Changes look good otherwise.
Have you considered keeping an include in reactDocgenTypescriptOptions to only target the packages we care about (manager and UI). Not sure about performance benefits but worth mentioning
dwiley-akamai
approved these changes
Nov 15, 2024
On the fence considering the marginal gain from added configuration. |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 46s |
| Commit |
|
| Committer | Hussain Khalil |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
452
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes docgen in Storybook, which is currently broken when launching through
yarn storybook. Docgen converts TSDoc comments into documentation for props and components.Changes 🔄
main.tsand the related utilitygetReactDocgenTSFileGlobs, which was broken by test: [M3-8809] - Add vitest workspace configuration #11184.Preview 📷
How to test 🧪
yarn storybook