fix: [M3-8923] - Fix Account Maintenance Account X-Filter #11277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
carrillo-erik and
hkhalil-akamai
and removed request for
a team
bnussman-akamai
commented
Nov 18, 2024
| @@ -49,7 +50,7 @@ export const LinodesRoutes = () => { | |||
| export const LinodesLandingWrapper = React.memo(() => { | |||
| const { data: accountMaintenanceData } = useAllAccountMaintenanceQuery( | |||
| {}, | |||
| { status: { '+or': ['pending, started'] } } | |||
There was a problem hiding this comment.
The primary fix was change the change 'pending, started' to 'pending', 'started'
The API would return 0 results because 'pending, started' is not a valid status. (I guess the API doesn't error in case of an invalid status on this endpoint)
| @@ -0,0 +1,3 @@ | |||
| export const PENDING_MAINTENANCE_FILTER = Object.freeze({ | |||
| status: { '+or': ['pending', 'started'] }, | |||
There was a problem hiding this comment.
This is the fixed filter. I just moved to to a shared constant because it is used in a handful of places.
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 453 passing tests on test run #2 ↗︎
|
hkhalil-akamai
approved these changes
Nov 19, 2024
jaalah-akamai
approved these changes
Nov 21, 2024
Cloud Manager E2E
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 34m 37s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
452
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/linode-storage.spec.ts • 2 failed tests
| Test | Artifacts | |
|---|---|---|
| linode storage tab > delete disk |
Screenshots
Video
|
|
| linode storage tab > add a disk |
Screenshots
Video
|
|
linodes/linode-storage.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| linode storage tab > resize disk |
Screenshots
Video
|
|
linodes/linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
linodes/clone-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
domains/smoke-clone-domain.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Clone a Domain > clones a domain |
Screenshots
Video
|
|
vpc/vpc-landing-page.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| VPC landing page > can update and delete VPCs from VPC landing page |
Screenshots
Video
|
|
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
GET /v4/account/maintenanceto not yield any resultsPreview 📷
Note
Without this change, none of the following maintenance banners / tooltips would show 😢
How to test 🧪
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅