Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8547] - Add unit tests for DocsLink component #11336

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

Added Unit test cases for DocsLink components.

Changes 🔄

  • Add unit test cases for DocsLink components.

Target release date 🗓️

N/A

How to test 🧪

Verification steps

(How to verify changes)

  • Run yarn test src/components/DocsLink --reporter verbose
  • Verify that all the test cases pass.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai requested a review from a team as a code owner November 27, 2024 12:37
@hasyed-akamai hasyed-akamai requested review from carrillo-erik and harsh-akamai and removed request for a team November 27, 2024 12:37
@hasyed-akamai hasyed-akamai self-assigned this Nov 27, 2024
@hasyed-akamai hasyed-akamai added Unit tests Improves unit test coverage Ready for Review labels Nov 27, 2024
Copy link

Coverage Report:
Base Coverage: 86.93%
Current Coverage: 86.96%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing454 Passing2 Skipped120m 33s

Details

Failing Tests
SpecTest
linode-config.spec.tsEnd-to-End » Clones a config

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 27, 2024
@harsh-akamai harsh-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 28, 2024
@harsh-akamai harsh-akamai merged commit 4f777b9 into linode:develop Nov 28, 2024
21 of 23 checks passed
Copy link

cypress bot commented Nov 28, 2024

Cloud Manager E2E    Run #6899

Run Properties:  status check failed Failed #6899  •  git commit 4f777b9a44: test: [M3-8547] - Add unit tests for `DocsLink` component (#11336)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6899
Run duration 32m 17s
Commit git commit 4f777b9a44: test: [M3-8547] - Add unit tests for `DocsLink` component (#11336)
Committer hasyed-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 461
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Boots a config Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  stackscripts/create-stackscripts.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Create stackscripts > creates a StackScript with Any/All target image Screenshots Video
Flakiness  linodes/update-linode-labels.spec.ts • 1 flaky test

View Output Video

Test Artifacts
update linode label > updates a linode label from details page Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Ready for Review Unit tests Improves unit test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants