Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8393] - Cypress test for Account Maintenance CSV downloads #11168

Conversation

subsingh-akamai
Copy link
Contributor

@subsingh-akamai subsingh-akamai commented Oct 28, 2024

Description 📝

Added cypress test for validating downloaded csv content of account maintenance with Pending and Completed status

Changes 🔄

Added below cypress tests under in spec file - cypress/e2e/core/account/account-maintenance.spec.ts

  • confirm maintenance details in the tables

Jira

  • M3-8393

How to test 🧪

yarn cy:run -s cypress/e2e/core/account/account-maintenance.spec.ts

Verification steps

When test executed using this command yarn cy:run -s cypress/e2e/core/account/account-maintenance.spec.tsall tests should pass successfully and you should see new test added as per below screenshot

image

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@subsingh-akamai subsingh-akamai requested review from a team as code owners October 28, 2024 09:19
@subsingh-akamai subsingh-akamai requested review from cliu-akamai, abailly-akamai and coliu-akamai and removed request for a team October 28, 2024 09:19
@subsingh-akamai subsingh-akamai marked this pull request as draft October 28, 2024 09:20
@subsingh-akamai subsingh-akamai added the e2e Indicates that a PR touches Cypress tests in some way label Oct 28, 2024
@subsingh-akamai subsingh-akamai self-assigned this Oct 28, 2024
@subsingh-akamai subsingh-akamai requested review from jdamore-linode and removed request for abailly-akamai October 28, 2024 09:26
@subsingh-akamai subsingh-akamai changed the title test: [M3-8383] - Cypress test for Account Maintenance CSV downloads test: [M3-8393] - Cypress test for Account Maintenance CSV downloads Oct 28, 2024
…ads' of github.com:subsingh-akamai/manager into M3-8393-Cypress-test-for-Account-Maintenance-CSV-downloads
@subsingh-akamai subsingh-akamai marked this pull request as ready for review November 4, 2024 05:34
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly curious about the new papaparse package this introduces - the last version was released ~1.5 years ago so I'm wondering about its maintainability (although there have been code updates as recent as ~2 months ago). On the other hand, the use cases here look small enough and this package doesn't seem to have other dependencies - @jdamore-linode what are your thoughts?

packages/manager/package.json Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 8, 2024

Coverage Report:
Base Coverage: 86.9%
Current Coverage: 86.9%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @subsingh-akamai!

✅ confirmed tests pass

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Subodh, this is looking really nice! I posted a couple suggestions, curious to hear your thoughts!

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! approving pending Joe's comments reviewed

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 20, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #12 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing452 Passing2 Skipped110m 46s

Details

Failing Tests
SpecTest
linode-config.spec.tsEnd-to-End » Clones a config
linode-storage.spec.tslinode storage tab » delete disk

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

@jdamore-linode jdamore-linode self-requested a review November 21, 2024 18:22
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @subsingh-akamai, looks great! You're good to disregard those test failures since they're unrelated to your PR's changes

@subsingh-akamai subsingh-akamai merged commit c59c943 into linode:develop Nov 22, 2024
22 of 23 checks passed
Copy link

cypress bot commented Nov 22, 2024

Cloud Manager E2E    Run #6866

Run Properties:  status check failed Failed #6866  •  git commit c59c9430ba: test: [M3-8393] - Cypress test for Account Maintenance CSV downloads (#11168)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6866
Run duration 33m 06s
Commit git commit c59c9430ba: test: [M3-8393] - Cypress test for Account Maintenance CSV downloads (#11168)
Committer subsingh-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 450
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/images/machine-image-upload.spec.ts • 4 failed tests

View Output Video

Test Artifacts
machine image > uploads machine image, mock finish event Screenshots Video
machine image > uploads machine image, mock upload canceled failed event Screenshots Video
machine image > uploads machine image, mock failed to decompress failed event Screenshots Video
machine image > uploads machine image, mock expired upload event Screenshots Video
Flakiness  linodes/switch-linode-state.spec.ts • 1 flaky test

View Output Video

Test Artifacts
switch linode state > reboots a linode from details page Screenshots Video
Flakiness  linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  volumes/delete-volume.spec.ts • 1 flaky test

View Output Video

Test Artifacts
volume delete flow > deletes a volume Screenshots Video

@subsingh-akamai subsingh-akamai deleted the M3-8393-Cypress-test-for-Account-Maintenance-CSV-downloads branch December 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants