-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8393] - Cypress test for Account Maintenance CSV downloads #11168
test: [M3-8393] - Cypress test for Account Maintenance CSV downloads #11168
Conversation
…entry in downloaded csv files
…aintenance-CSV-downloads
…ads' of github.com:subsingh-akamai/manager into M3-8393-Cypress-test-for-Account-Maintenance-CSV-downloads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly curious about the new papaparse package this introduces - the last version was released ~1.5 years ago so I'm wondering about its maintainability (although there have been code updates as recent as ~2 months ago). On the other hand, the use cases here look small enough and this package doesn't seem to have other dependencies - @jdamore-linode what are your thoughts?
packages/manager/cypress/e2e/core/account/account-maintenance.spec.ts
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @subsingh-akamai!
✅ confirmed tests pass
…aintenance-CSV-downloads
…aintenance-CSV-downloads
…loaded file after assertion
…ads' of github.com:subsingh-akamai/manager into M3-8393-Cypress-test-for-Account-Maintenance-CSV-downloads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Subodh, this is looking really nice! I posted a couple suggestions, curious to hear your thoughts!
packages/manager/cypress/e2e/core/account/account-maintenance.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/account-maintenance.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/account-maintenance.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! approving pending Joe's comments reviewed
…aintenance-CSV-downloads
…ads' of github.com:subsingh-akamai/manager into M3-8393-Cypress-test-for-Account-Maintenance-CSV-downloads
Cloud Manager UI test results🔺 2 failing tests on test run #12 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @subsingh-akamai, looks great! You're good to disregard those test failures since they're unrelated to your PR's changes
Description 📝
Added cypress test for validating downloaded csv content of account maintenance with Pending and Completed status
Changes 🔄
Added below cypress tests under in spec file - cypress/e2e/core/account/account-maintenance.spec.ts
Jira
How to test 🧪
yarn cy:run -s cypress/e2e/core/account/account-maintenance.spec.ts
Verification steps
When test executed using this command
yarn cy:run -s cypress/e2e/core/account/account-maintenance.spec.ts
all tests should pass successfully and you should see new test added as per below screenshotAs an Author I have considered 🤔
Check all that apply