-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8644] - Move Checkbox
to linode/ui
package
#11279
refactor: [M3-8644] - Move Checkbox
to linode/ui
package
#11279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @hasyed-akamai!
Also need a changeset remove
changeset for manager
indicating we're moving this to UI package
Co-authored-by: Purvesh Makode <[email protected]>
Coverage Report: ❌ |
oh! - inside Checkbox.tsx, the import for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks @hasyed-akamai! Approving pending the import change I commented
Cloud Manager UI test results🎉 453 passing tests on test run #5 ↗︎
|
Cloud Manager E2E Run #6860
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6860
|
Run duration | 33m 51s |
Commit |
f7a2793e6f: refactor: [M3-8644] - Move `Checkbox` to `linode/ui` package (#11279)
|
Committer | hasyed-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
3
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
451
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/linode-storage.spec.ts • 3 failed tests
Test | Artifacts | |
---|---|---|
linode storage tab > delete disk |
Screenshots
Video
|
|
linode storage tab > add a disk |
Screenshots
Video
|
|
linode storage tab > resize disk |
Screenshots
Video
|
switch-linode-state.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
switch linode state > powers off a linode from details page |
Screenshots
Video
|
linode-config.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
clone-linode.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
Description 📝
Migrate
Checkbox
tolinode/ui
package.Target release date 🗓️
N/A
How to test 🧪
Check all that apply