Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8644] - Move Checkbox to linode/ui package #11279

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

Migrate Checkbox to linode/ui package.

Target release date 🗓️

N/A

How to test 🧪

  • All tests should pass
  • There should be no adverse impacts observed in Cloud

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai marked this pull request as ready for review November 19, 2024 07:14
@hasyed-akamai hasyed-akamai requested a review from a team as a code owner November 19, 2024 07:14
@hasyed-akamai hasyed-akamai requested review from coliu-akamai and pmakode-akamai and removed request for a team November 19, 2024 07:14
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hasyed-akamai!

Also need a changeset remove changeset for manager indicating we're moving this to UI package

packages/ui/.changeset/pr-11279-added-1731998133269.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 19, 2024

Coverage Report:
Base Coverage: 86.9%
Current Coverage: 86.86%

@coliu-akamai
Copy link
Contributor

coliu-akamai commented Nov 19, 2024

seeing the following when running storybook on the checkbox's Tooltip and Label And Tooltip stories on this branch - is anyone else seeing the same?

@coliu-akamai
Copy link
Contributor

oh! - inside Checkbox.tsx, the import for TooltipIcon can't be from linode/ui bc that creates a circular dependency. We'll need to update that to the relative import: import { TooltipIcon } from '../TooltipIcon';

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks @hasyed-akamai! Approving pending the import change I commented

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Nov 19, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 453 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing453 Passing2 Skipped84m 18s

@pmakode-akamai pmakode-akamai merged commit f7a2793 into linode:develop Nov 21, 2024
23 checks passed
Copy link

cypress bot commented Nov 21, 2024

Cloud Manager E2E    Run #6860

Run Properties:  status check failed Failed #6860  •  git commit f7a2793e6f: refactor: [M3-8644] - Move `Checkbox` to `linode/ui` package (#11279)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6860
Run duration 33m 51s
Commit git commit f7a2793e6f: refactor: [M3-8644] - Move `Checkbox` to `linode/ui` package (#11279)
Committer hasyed-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 451
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/linode-storage.spec.ts • 3 failed tests

View Output Video

Test Artifacts
linode storage tab > delete disk Screenshots Video
linode storage tab > add a disk Screenshots Video
linode storage tab > resize disk Screenshots Video
Flakiness  switch-linode-state.spec.ts • 1 flaky test

View Output Video

Test Artifacts
switch linode state > powers off a linode from details page Screenshots Video
Flakiness  linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants