Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8919] - Fix Linode migration test failure caused by region label conflict #11274

Merged

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

This fixes a consistent test failure in migrate-linode.spec.ts that was triggered by the launch of Frankfurt 2 earlier today.

The test attempts to confirm that users cannot migrate a Linode to the same region the Linode exists in. It does this by typing the Frankfurt region's label into the autocomplete and asserting that there are no results, and the launch of Frankfurt 2 triggered the failure because the "No results" message no longer appears.

This fixes the issue by searching for the region by ID, circumventing the label conflicts altogether.

Changes 🔄

  • Rework region assertions to prevent region label conflicts from causing test failures
  • Remove calls to deprecated helpers fbtClick and getClick

Target release date 🗓️

N/A.

How to test 🧪

Prerequisites

Build and serve Cloud, then run the migrate tests:

yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts"
  • Confirm that all 3 tests pass, particularly shows DC-specific pricing information when migrating linodes to similarly priced DCs

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode requested a review from a team as a code owner November 18, 2024 18:59
@jdamore-linode jdamore-linode requested review from AzureLatte and removed request for a team November 18, 2024 18:59
@jdamore-linode jdamore-linode self-assigned this Nov 18, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner November 18, 2024 19:02
@jdamore-linode jdamore-linode requested review from cpathipa and coliu-akamai and removed request for a team November 18, 2024 19:02
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdamore-linode !

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Nov 18, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed test passes

thanks Joe! 🎉

Copy link

github-actions bot commented Nov 18, 2024

Coverage Report:
Base Coverage: 86.9%
Current Coverage: 86.9%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 452 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing452 Passing2 Skipped84m 7s

@jdamore-linode jdamore-linode merged commit 1059742 into linode:develop Nov 18, 2024
23 checks passed
Copy link

cypress bot commented Nov 18, 2024

Cloud Manager E2E    Run #6841

Run Properties:  status check passed Passed #6841  •  git commit 105974283c: test: [M3-8919] - Fix Linode migration test failure caused by region label confl...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6841
Run duration 26m 51s
Commit git commit 105974283c: test: [M3-8919] - Fix Linode migration test failure caused by region label confl...
Committer jdamore-linode
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 452
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants