-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8919] - Fix Linode migration test failure caused by region label conflict #11274
Merged
jdamore-linode
merged 3 commits into
linode:develop
from
jdamore-linode:M3-8919-fix-migration-test
Nov 18, 2024
Merged
test: [M3-8919] - Fix Linode migration test failure caused by region label conflict #11274
jdamore-linode
merged 3 commits into
linode:develop
from
jdamore-linode:M3-8919-fix-migration-test
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
AzureLatte
and removed request for
a team
November 18, 2024 18:59
jdamore-linode
requested review from
cpathipa and
coliu-akamai
and removed request for
a team
November 18, 2024 19:02
abailly-akamai
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jdamore-linode !
jaalah-akamai
approved these changes
Nov 18, 2024
coliu-akamai
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed test passes
thanks Joe! 🎉
Coverage Report: ✅ |
Cloud Manager UI test results🎉 452 passing tests on test run #3 ↗︎
|
Cloud Manager E2E Run #6841
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6841
|
Run duration | 26m 51s |
Commit |
105974283c: test: [M3-8919] - Fix Linode migration test failure caused by region label confl...
|
Committer | jdamore-linode |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
452
|
View all changes introduced in this branch ↗︎ |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This fixes a consistent test failure in
migrate-linode.spec.ts
that was triggered by the launch of Frankfurt 2 earlier today.The test attempts to confirm that users cannot migrate a Linode to the same region the Linode exists in. It does this by typing the Frankfurt region's label into the autocomplete and asserting that there are no results, and the launch of Frankfurt 2 triggered the failure because the "No results" message no longer appears.
This fixes the issue by searching for the region by ID, circumventing the label conflicts altogether.
Changes 🔄
fbtClick
andgetClick
Target release date 🗓️
N/A.
How to test 🧪
Prerequisites
Build and serve Cloud, then run the migrate tests:
yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts"
shows DC-specific pricing information when migrating linodes to similarly priced DCs
As an Author, I have considered 🤔