Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8909] - Migrate EditableText to ui package #11308

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Nov 22, 2024

Description 📝

Moves the EditableText component to the @linode/ui package and updates existing imports.

Changes 🔄

  • Move EditableText component to @linode/ui package
  • Update existing imports
  • Added remaining react eslint rules and specific rules related to this component/story

Target release date 🗓️

N/A

How to test 🧪

  • Confirm all checks pass
  • Confirm all the necessary imports are updated
  • Confirm nothing on CM and Storybook breaks
    • Ensure everything works as expected wherever EditableText is used
    • Run rm -r packages/manager/node_modules/.cache + clear your browser cache before testing Storybook

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai changed the title refactor: [M3-8909] - Migrate EditableText to ui package refactor: [M3-8909] - Migrate EditableText to ui package Nov 22, 2024
@pmakode-akamai pmakode-akamai self-assigned this Nov 22, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review November 22, 2024 12:57
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner November 22, 2024 12:57
@pmakode-akamai pmakode-akamai requested review from mjac0bs and hkhalil-akamai and removed request for a team November 22, 2024 12:57
@pmakode-akamai pmakode-akamai marked this pull request as draft November 22, 2024 13:20
@pmakode-akamai pmakode-akamai marked this pull request as ready for review November 22, 2024 13:23
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Purvesh!

  • Confirm all checks pass (machine-image.spec.ts seems to be unrelatedly flaky today)
  • Confirm all the necessary imports are updated
  • Confirm nothing on CM and Storybook breaks
    • Ensure everything works as expected wherever EditableText is used

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Nov 22, 2024
@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 22, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 6 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
6 Failing449 Passing2 Skipped129m 3s

Details

Failing Tests
SpecTest
machine-image-upload.spec.tsmachine image » uploads machine image, mock upload canceled failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock failed to decompress failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock expired upload event
linode-config.spec.tsEnd-to-End » Edits a config
linode-config.spec.tsEnd-to-End » Clones a config
rescue-linode.spec.tsRescue Linodes » Can reboot a Linode into rescue mode

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/linodes/rescue-linode.spec.ts"

@pmakode-akamai pmakode-akamai merged commit f2653ad into linode:develop Nov 25, 2024
22 of 23 checks passed
Copy link

cypress bot commented Nov 25, 2024

Cloud Manager E2E    Run #6874

Run Properties:  status check failed Failed #6874  •  git commit f2653ad808: refactor: [M3-8909] - Migrate `EditableText` to `ui` package (#11308)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6874
Run duration 35m 56s
Commit git commit f2653ad808: refactor: [M3-8909] - Migrate `EditableText` to `ui` package (#11308)
Committer Purvesh D M
View all properties for this run ↗︎

Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 449
View all changes introduced in this branch ↗︎

Tests for review

Failed  images/machine-image-upload.spec.ts • 4 failed tests

View Output Video

Test Artifacts
machine image > uploads machine image, mock finish event Screenshots Video
machine image > uploads machine image, mock upload canceled failed event Screenshots Video
machine image > uploads machine image, mock failed to decompress failed event Screenshots Video
machine image > uploads machine image, mock expired upload event Screenshots Video
Failed  linodes/rebuild-linode.spec.ts • 2 failed tests

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
rebuild linode > rebuilds a linode from Account StackScript Screenshots Video
Flakiness  linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Boots a config Screenshots Video
Flakiness  volumes/delete-volume.spec.ts • 1 flaky test

View Output Video

Test Artifacts
volume delete flow > deletes a volume Screenshots Video
Flakiness  placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants