-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8909] - Migrate EditableText
to ui
package
#11308
Merged
pmakode-akamai
merged 3 commits into
linode:develop
from
pmakode-akamai:M3-8909-move-editabletext-to-ui-package
Nov 25, 2024
Merged
refactor: [M3-8909] - Migrate EditableText
to ui
package
#11308
pmakode-akamai
merged 3 commits into
linode:develop
from
pmakode-akamai:M3-8909-move-editabletext-to-ui-package
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
changed the title
refactor: [M3-8909] - Migrate EditableText to
refactor: [M3-8909] - Migrate Nov 22, 2024
ui
packageEditableText
to ui
package
pmakode-akamai
requested review from
mjac0bs and
hkhalil-akamai
and removed request for
a team
November 22, 2024 12:57
mjac0bs
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Purvesh!
- Confirm all checks pass (machine-image.spec.ts seems to be unrelatedly flaky today)
- Confirm all the necessary imports are updated
- Confirm nothing on CM and Storybook breaks
- Ensure everything works as expected wherever EditableText is used
jaalah-akamai
approved these changes
Nov 22, 2024
jaalah-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Nov 22, 2024
Cloud Manager UI test results🔺 6 failing tests on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/linodes/rescue-linode.spec.ts" |
hkhalil-akamai
approved these changes
Nov 23, 2024
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Moves the
EditableText
component to the@linode/ui
package and updates existing imports.Changes 🔄
EditableText
component to@linode/ui
packageTarget release date 🗓️
N/A
How to test 🧪
EditableText
is usedrm -r packages/manager/node_modules/.cache
+ clear your browser cache before testing StorybookAs an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅