Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8918] - Cypress test for restricted user Image empty landing page #11281

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

Added cypress test for restricted user Image Empty landing page

Changes 🔄

Added below cypress tests under in spec file - cypress/e2e/core/images/images-empty-landing-page.spec.ts

  • checks restricted user has no access to create Image on Image Empty landing page

How to test 🧪

yarn cy:run -s cypress/e2e/core/images/images-empty-landing-page.spec.ts

Verification steps

When test executed using this command yarn cy:run -s cypress/e2e/core/images/images-empty-landing-page.spec.ts all tests should pass successfully.

Tests

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai self-assigned this Nov 19, 2024
@hasyed-akamai hasyed-akamai added Testing e2e Indicates that a PR touches Cypress tests in some way Work in Progress and removed Testing labels Nov 19, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 454 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing454 Passing2 Skipped93m 46s

@hasyed-akamai hasyed-akamai marked this pull request as ready for review November 20, 2024 03:33
@hasyed-akamai hasyed-akamai requested review from a team as code owners November 20, 2024 03:33
@hasyed-akamai hasyed-akamai requested review from jdamore-linode, carrillo-erik and abailly-akamai and removed request for a team November 20, 2024 03:33
@subsingh-akamai subsingh-akamai marked this pull request as draft November 21, 2024 08:03
@subsingh-akamai subsingh-akamai marked this pull request as ready for review November 21, 2024 11:06
@subsingh-akamai subsingh-akamai requested review from cliu-akamai and coliu-akamai and removed request for subsingh-akamai and cliu-akamai November 21, 2024 11:07
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed test passes, code review + checked acceptance criteria

thanks Haneef!

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Nov 21, 2024
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hasyed-akamai, high quality!

Approved pending any final suggestions from @subsingh-akamai

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 21, 2024
@subsingh-akamai
Copy link
Contributor

Approved from my side as well.. Great work Haneef :-)

@hasyed-akamai hasyed-akamai merged commit 4b3fe8a into linode:develop Nov 22, 2024
23 checks passed
Copy link

cypress bot commented Nov 22, 2024

Cloud Manager E2E    Run #6868

Run Properties:  status check failed Failed #6868  •  git commit 4b3fe8aee5: test: [M3-8918] - Cypress test for restricted user Image empty landing page (#11...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6868
Run duration 32m 23s
Commit git commit 4b3fe8aee5: test: [M3-8918] - Cypress test for restricted user Image empty landing page (#11...
Committer hasyed-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 451
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/images/machine-image-upload.spec.ts • 4 failed tests

View Output Video

Test Artifacts
machine image > uploads machine image, mock finish event Screenshots Video
machine image > uploads machine image, mock upload canceled failed event Screenshots Video
machine image > uploads machine image, mock failed to decompress failed event Screenshots Video
machine image > uploads machine image, mock expired upload event Screenshots Video
Flakiness  parentChild/account-switching.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Parent/Child account switching > From Parent to Child > can switch from Parent account user to Proxy account user from Billing page Screenshots Video
Flakiness  objectStorageGen2/bucket-object-gen2.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Object Storage Gen2 bucket object tests > can check Object details drawer with E0 endpoint type Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants