Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8430] - Mock disable OBJ Gen 2 flags for existing OBJ Cypress tests #11191

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 30, 2024

Description 📝

Ensures that existing OBJ cypress tests (those not in the ObjectStorageGen2 package) will not have any UI from OBJ gen 2 showing up

Changes 🔄

  • mock gen2 flag as false for obj legacy/multicluster tests
  • make sure obj gen2 account capability is not included in mocks

Target release date 🗓️

n/a

How to test 🧪

Ensure all tests in the objectStorage package continue to pass

yarn cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"
yarn cy:run -s "cypress/e2e/core/objectStorage/access-keys.smoke.spec.ts"
yarn cy:run -s "cypress/e2e/core/objectStorage/enable-object-storage.spec.ts"
yarn cy:run -s "cypress/e2e/core/objectStorage/object-storage-errors.spec.ts"
yarn cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"
yarn cy:run -s "cypress/e2e/core/objectStorage/object-storage.smoke.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai marked this pull request as ready for review October 31, 2024 19:36
@coliu-akamai coliu-akamai requested a review from a team as a code owner October 31, 2024 19:36
@coliu-akamai coliu-akamai requested review from jdamore-linode and removed request for a team October 31, 2024 19:36
@coliu-akamai coliu-akamai requested a review from a team as a code owner October 31, 2024 19:38
@coliu-akamai coliu-akamai requested review from carrillo-erik and cpathipa and removed request for a team October 31, 2024 19:38
Copy link

Coverage Report:
Base Coverage: 87.22%
Current Coverage: 87.22%

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 13, 2024
@coliu-akamai coliu-akamai merged commit 9209bc2 into linode:develop Nov 13, 2024
23 checks passed
Copy link

cypress bot commented Nov 13, 2024

Cloud Manager E2E    Run #6818

Run Properties:  status check passed Passed #6818  •  git commit 9209bc2436: test: [M3-8430] - Mock disable OBJ Gen 2 flags for existing OBJ Cypress tests (#...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6818
Run duration 41m 09s
Commit git commit 9209bc2436: test: [M3-8430] - Mock disable OBJ Gen 2 flags for existing OBJ Cypress tests (#...
Committer Connie Liu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 445
View all changes introduced in this branch ↗︎

santoshp210-akamai pushed a commit to santoshp210-akamai/manager that referenced this pull request Nov 14, 2024
…ss tests (linode#11191)

* update existing obj cypress tests to mock obj gen 2 flags as disabled

* update access-key spec

* Added changeset: Mock disable OBJ Gen 2 flags for existing OBJ Cypress tests
@coliu-akamai coliu-akamai deleted the m3-8430 branch November 27, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Object Storage Gen2 Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants