Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Update PULL_REQUEST_TEMPLATE (Part 3) #11325

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Nov 25, 2024

Description 📝

Makes some changes we discussed at last Thursday's cafe. Feel free to push further changes if this is reviewed while I'm out if changes are requested to satisfy the team.

Changes 🔄

  • Removes the bullets from the list
  • Updates the consideration checklist heading to add incentive (to get reviewed faster)
  • Puts both checklists under a collapsible section, rather than adds a note about deletion prior to PR review

Preview 📷

Screenshot 2024-11-25 at 12 13 05 PM
Screenshot 2024-11-25 at 12 17 49 PM

How to test 🧪

Prerequisites

Verification steps

(How to verify changes)

  • Check out the diff.

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs added the Documentation Improving / adding to our documentation label Nov 25, 2024
@mjac0bs mjac0bs self-assigned this Nov 25, 2024
@mjac0bs mjac0bs requested a review from a team as a code owner November 25, 2024 20:16
@mjac0bs mjac0bs requested review from hana-akamai, coliu-akamai and abailly-akamai and removed request for a team November 25, 2024 20:16
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 455 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing455 Passing2 Skipped91m 40s

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 26, 2024
@hana-akamai hana-akamai merged commit 640d7a6 into linode:develop Nov 26, 2024
22 of 23 checks passed
Copy link

cypress bot commented Nov 26, 2024

Cloud Manager E2E    Run #6885

Run Properties:  status check failed Failed #6885  •  git commit 640d7a6bd5: change: Update PULL_REQUEST_TEMPLATE (Part 3) (#11325)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6885
Run duration 38m 42s
Commit git commit 640d7a6bd5: change: Update PULL_REQUEST_TEMPLATE (Part 3) (#11325)
Committer Mariah Jacobs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 5
Tests that were flaky  Flaky 8
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 450
View all changes introduced in this branch ↗︎

Tests for review

Failed  linodes/switch-linode-state.spec.ts • 1 failed test

View Output Video

Test Artifacts
switch linode state > powers off a linode from details page Screenshots Video
Failed  linodes/rebuild-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Image Screenshots Video
Failed  linodes/linode-config.spec.ts • 2 failed tests

View Output Video

Test Artifacts
Linode Config management > End-to-End > Boots a config Screenshots Video
Linode Config management > End-to-End > Clones a config Screenshots Video
Failed  stackscripts/create-stackscripts.spec.ts • 1 failed test

View Output Video

Test Artifacts
Create stackscripts > creates a StackScript with Any/All target image Screenshots Video
Flakiness  switch-linode-state.spec.ts • 2 flaky tests

View Output Video

Test Artifacts
switch linode state > powers on a linode from details page Screenshots Video
switch linode state > reboots a linode from details page Screenshots Video
Flakiness  resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by increasing size when offline: cold migration Screenshots Video
Flakiness  rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
Flakiness  linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Edits a config Screenshots Video
Flakiness  clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video

The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Documentation Improving / adding to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants