HasLabel implementation v14 #14279
Closed
HasLabel implementation v14 #14279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tatu Lund <[email protected]>
Fix issue with URLDecoder handling of '+' character. Fixes #12354 Co-authored-by: caalador <[email protected]>
Co-authored-by: caalador <[email protected]>
…12478) Fixes a bug where the stream of BeforeEnterObservers could contain duplicates, causing extraneous calls to BeforeEnterObserver::beforeEnter for non-root components. Fixes #12356 Co-authored-by: Johannes Eriksson <[email protected]>
Update ASM to support Java 17 Co-authored-by: Matti Tahvonen <[email protected]> Co-authored-by: caalador <[email protected]> Co-authored-by: Matti Tahvonen <[email protected]>
Co-authored-by: Tarek Oraby <[email protected]> Co-authored-by: caalador <[email protected]> Co-authored-by: Tarek Oraby <[email protected]>
touches #12489 Co-authored-by: caalador <[email protected]>
…12531) (#12591) (#12596) Fixes #12100 Co-authored-by: Artur <[email protected]> Co-authored-by: caalador <[email protected]> Co-authored-by: Artur <[email protected]>
Co-authored-by: Artur <[email protected]>
Checking the logs for errors will wait for vaadin to be ready also. Co-authored-by: caalador <[email protected]>
) (#12633) (#12639) fixes #10924 Co-authored-by: Matti Tahvonen <[email protected]>
Update exception for failing to remove node_modules folder. Closes #12655 Co-authored-by: caalador <[email protected]>
Check if `node -p 'crypto.createHash("md4")'` works. If not,
pass the `--openssl-legacy-provider` flag. Workaround for:
webpack/webpack#14532
Fixes #12649
Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees. Co-authored-by: Johannes Eriksson <[email protected]>
Get the push suspend timout parameter from the configuration as atmosphere doesn't read it from anywhere. Fixes #12559 Co-authored-by: caalador <[email protected]>
Works around connection issue with webpack-dev-server 3.11.0 and Node 17+ Co-authored-by: Johannes Eriksson <[email protected]>
Use node version and url properties if defined. Force home node also in plugin if set. part of #12686
When copying the local frontend files remove any read-only flags from the copies. fixes #12711 Co-authored-by: caalador <[email protected]>
If the version in vaadin or dependenices is not a valid version, but a string like next/latest compare string content to determine if they equal. Co-authored-by: caalador <[email protected]>
Co-authored-by: Johannes Eriksson <[email protected]>
This fixes some random build issues where webpack exits with code 139 Co-authored-by: Artur <[email protected]>
The builder was executed twice, most likely due to a merge conflict. Co-authored-by: caalador <[email protected]>
…ing assertions (#12830) Sometimes findElements(By.tagNvame("div")) seems to return results before server roundtrips are completed, so list of elements is missing elements. Performing a direct searching for child element by xpath (findElement(By.xpath("div[N]")))) seem always to work. To be noted that xpath position is 1 based Fixes #10481, #10487, #10491
Do not throw silently for incompatible import paths. Fix comment removal for JS files to accept ' as string. fixes #12765 Co-authored-by: caalador <[email protected]>
Do not set permissions nor follow symlinks when deleting node_modules. Fixes #12810 Co-authored-by: Johannes Eriksson <[email protected]>
No other converter logs a conversion error, which makes sense as you do not want to see all invalid input in your server logs
… (#13774) Move clean-frontend to pre-clean as if mvn clean is executed before clean-frontend clean will remove the target folder making removal of node_modules fail on windows if there is a symlink to target/flow-frontend touches #13760 Co-authored-by: caalador <[email protected]>
#13779) Ignore CancellationException if the task is cancelled in the meantime. Authored-by: @HawkSK Fixes #13610 Co-authored-by: @mshabarov Co-authored-by: Mikhail Shabarov <[email protected]>
Fixes #12939 Co-authored-by: caalador <[email protected]>
…tor (#13746) (#13818) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Pepijn Van Eeckhoudt <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
) When navigating to a non-existent route in dev mode, an error page is displayed with the list of the available routes. However, as noted by @dmitrilc, this list doesn't include routes defined via the @RouteAlias annotation. Co-authored-by: Tarek Oraby <[email protected]>
…13733) (#13805) Process re-sync messages via normal message queue and use semaphore to protect re-sync process (i.e. do not allow other messages while performing re-sync). This PR is adopted from similar fixes for Vaadin 8. vaadin/framework#11791 vaadin/framework#12043 vaadin/framework#12178 This also changes the method `forceMessageHandling` in a way that the desire to resynchronise is registered before calling `endRequest`. If this is not done, `endRequest` may end up sending out a request itself and that then causes the re-sync request to fail because a request is already in flight. This ends up throwing an IllegalStateException at com/vaadin/client/communication/RequestResponseTracker.java. Fixes #13726 Co-authored-by: Artur <[email protected]> Co-authored-by: Pepijn Van Eeckhoudt @pepijnve Co-authored-by: Tatu Lund <[email protected]> Co-authored-by: Artur <[email protected]>
…less cases (#13400) (#13799) Closes: vaadin/flow-components#1157 Co-authored-by: Tatu Lund <[email protected]>
…#13620) Check if parent registry contains a better match than the session registry. Fixes #13348 Co-authored-by: caalador <[email protected]>
* fix: Use KeyMapper by default for unique keys * fix: Use KeyMapper by default to generate unique keys Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row. Part-of: vaadin/flow-components#3156 (cherry picked from commit 570244d)
#13940) (CP: 2.7) (#13997) * feat: enable components to notify binder when validation state changes (#13940) Co-authored-by: Mikhail Shabarov <[email protected]>
* chore: fix HasValidator javadoc (#14113) The error in javadoc example is fixed so the getDefaultValidator represent the correct implementation. Co-authored-by: Soroosh Taefi <[email protected]>
…#14195) * fix: Let DataCommunicator#flush keep track of its StateTree fix: Let DataCommunicator#flush keep track of which StateTree is supposed to execute its flushRequest (#14068) * DataCommunicator#flush can be stuck when moving between UI instances, for instance when the @PreserveOnRefresh annotation is present. Co-authored-by: Willem Verstraeten <[email protected]> Co-authored-by: Marco Collovati [email protected] (cherry picked from commit c55bdcc)
…on binder (#14205) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and vaadin/flow-components#3406 (comment) (cherry picked from commit 420498c) Co-authored-by: Knoobie <[email protected]>
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
requested changes
Aug 5, 2022
There was a problem hiding this comment.
@melihkurtaran thank you for contribution!
Seems something goes wrong and a tons of commits are now going to be merged.
Probably you cherry picked from master to your branch which is on top of 2.7.
Then you changed GH target branch to 2.8.
Please pick the needed commit on top of 2.8 branch instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature: Backporting HasLabel-Interface to Vaadin 14 #14277
Type of change
Checklist
Additional for
Featuretype of change