fix: Move the clean-frontend phase to be before clean (#13763) #13764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move clean-frontend to pre-clean as if mvn clean is executed before clean-frontend clean will remove the target folder making removal of node_modules fail on windows if there is a symlink to target/flow-frontend touches #13760
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
approved these changes
May 13, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
May 13, 2022
Move clean-frontend to pre-clean as if mvn clean is executed before clean-frontend clean will remove the target folder making removal of node_modules fail on windows if there is a symlink to target/flow-frontend touches #13760
vaadin-bot
added a commit
that referenced
this pull request
May 13, 2022
… (#13774) Move clean-frontend to pre-clean as if mvn clean is executed before clean-frontend clean will remove the target folder making removal of node_modules fail on windows if there is a symlink to target/flow-frontend touches #13760 Co-authored-by: caalador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend
touches #13760