Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move the clean-frontend phase to be before clean #13763

Merged
merged 1 commit into from
May 13, 2022

Conversation

caalador
Copy link
Contributor

Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760

Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760
caalador added a commit that referenced this pull request May 13, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Unit Test Results

   965 files  ±0     965 suites  ±0   44m 14s ⏱️ - 1m 11s
6 274 tests ±0  6 226 ✔️ +1  48 💤 ±0  0 ±0 
6 502 runs  +3  6 448 ✔️ +4  54 💤 ±0  0 ±0 

Results for commit a24e0a8. ± Comparison against base commit 3512997.

mshabarov pushed a commit that referenced this pull request May 13, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760
@mshabarov mshabarov merged commit 177c9b1 into master May 13, 2022
@mshabarov mshabarov deleted the issues/13760_move_clean-frontend_phase branch May 13, 2022 13:26
vaadin-bot pushed a commit that referenced this pull request May 13, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760
vaadin-bot pushed a commit that referenced this pull request May 13, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760
vaadin-bot pushed a commit that referenced this pull request May 13, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760
vaadin-bot pushed a commit that referenced this pull request May 13, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760
vaadin-bot added a commit that referenced this pull request May 13, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760

Co-authored-by: caalador <[email protected]>
vaadin-bot added a commit that referenced this pull request May 13, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760

Co-authored-by: caalador <[email protected]>
vaadin-bot added a commit that referenced this pull request May 13, 2022
… (#13774)

Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760

Co-authored-by: caalador <[email protected]>
mshabarov pushed a commit that referenced this pull request May 16, 2022
Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760

Co-authored-by: caalador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants