Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move the clean-frontend phase to be before clean (#13763) (CP: 23.1) #13775

Merged
merged 1 commit into from
May 13, 2022

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Move clean-frontend to pre-clean as if
mvn clean is executed before clean-frontend
clean will remove the target folder making
removal of node_modules fail on windows
if there is a symlink to target/flow-frontend

touches #13760
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Unit Test Results

   962 files  ±0     962 suites  ±0   56m 26s ⏱️ + 2m 31s
6 271 tests ±0  6 222 ✔️ ±0  49 💤 ±0  0 ±0 
6 496 runs   - 3  6 441 ✔️  - 3  55 💤 ±0  0 ±0 

Results for commit 51c04c0. ± Comparison against base commit 903bfa1.

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 5219122 into 23.1 May 13, 2022
@vaadin-bot vaadin-bot deleted the cherry-pick-13763-to-23.1-1652448619723 branch May 13, 2022 14:20
@vaadin-bot
Copy link
Collaborator Author

This PR has been merged with 'squash' method.[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 23.1.0.beta2 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants