Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add wepack dev server parameter --host=127.0.0.1 #12710

Merged
merged 1 commit into from
Jan 13, 2022
Merged

fix: add wepack dev server parameter --host=127.0.0.1 #12710

merged 1 commit into from
Jan 13, 2022

Conversation

joheriks
Copy link
Contributor

Works around connection issue with webpack-dev-server 3.11.0 and Node 17+.

Fixes #12546.

@joheriks joheriks changed the title fix: add wepack dev server host parameter 127.0.0.1 fix: add wepack dev server --host parameter 127.0.0.1 Jan 12, 2022
@joheriks joheriks changed the title fix: add wepack dev server --host parameter 127.0.0.1 fix: add wepack dev server parameter --host=127.0.0.1 Jan 12, 2022
fix: Pass --host=127.0.0.1 to webpack-dev-server
ff7b24d 
Works around connection issue with webpack-dev-server 3.11.0 and Node 17+
@joheriks joheriks force-pushed the joheriks/add-wepack-dev-server-host-parameter-127.0.0.1 branch from 03c2f56 to ff7b24d Compare January 12, 2022 15:20
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 7 issues

  1. MAJOR DevModeHandler.java#L321: Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. rule
  2. MAJOR DevModeHandler.java#L468: Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. rule
  3. MAJOR DevModeHandler.java#L473: Invoke method(s) only conditionally. rule
  4. MAJOR DevModeHandler.java#L475: Invoke method(s) only conditionally. rule
  5. MAJOR DevModeHandler.java#L477: Invoke method(s) only conditionally. rule
  6. MAJOR DevModeHandler.java#L695: Invoke method(s) only conditionally. rule
  7. MAJOR DevModeHandler.java#L706: Either re-interrupt this method or rethrow the "InterruptedException". rule

@caalador caalador merged commit e1771ed into 2.8 Jan 13, 2022
@caalador caalador deleted the joheriks/add-wepack-dev-server-host-parameter-127.0.0.1 branch January 13, 2022 04:44
vaadin-bot pushed a commit that referenced this pull request Jan 13, 2022
@vaadin-bot
fix: Pass --host=127.0.0.1 to webpack-dev-server (#12710)
ab5579f 
Works around connection issue with webpack-dev-server 3.11.0 and Node 17+
vaadin-bot added a commit that referenced this pull request Jan 13, 2022
@vaadin-bot
fix: Pass --host=127.0.0.1 to webpack-dev-server (#12710) (#12713)
3cd2d57 
Works around connection issue with webpack-dev-server 3.11.0 and Node 17+

Co-authored-by: Johannes Eriksson <[email protected]>
@joheriks joheriks mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.7 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joheriks @vaadin-bot @caalador