Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing media-queries and resources for PWA splash screen #13923

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Jun 7, 2022

Description

Missing media queries and meta resources
caused the PWA splash screen not to show
up on Apple devices.

Fixes: #13617

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed a self-review and corrected misspellings.

Missing media-queries and meta resources
caused PWA splash screen do not show up
on Apple devices.

Fixes: #13617
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Unit Test Results

   972 files  +23     972 suites  +23   53m 54s ⏱️ + 5m 12s
6 311 tests +28  6 263 ✔️ +28  48 💤 ±0  0 ±0 
6 541 runs  +60  6 487 ✔️ +60  54 💤 ±0  0 ±0 

Results for commit dfd3ec5. ± Comparison against base commit 570244d.

♻️ This comment has been updated with latest results.

@taefi taefi added +0.0.1 and removed +1.0.0 labels Jun 7, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mshabarov mshabarov merged commit e0c2c70 into master Jun 10, 2022
@mshabarov mshabarov deleted the taefi/fix-pwa-registry branch June 10, 2022 11:52
vaadin-bot pushed a commit that referenced this pull request Jun 10, 2022
…13923)

Missing media-queries and meta resources
caused PWA splash screen do not show up
on Apple devices.

Fixes: #13617
vaadin-bot pushed a commit that referenced this pull request Jun 10, 2022
…13923)

Missing media-queries and meta resources
caused PWA splash screen do not show up
on Apple devices.

Fixes: #13617
@vaadin-bot
Copy link
Collaborator

Hi @taefi and @mshabarov, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick e0c2c70
error: could not apply e0c2c70... fix: Add missing media-queries and resources for PWA splash screen (#13923)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot pushed a commit that referenced this pull request Jun 10, 2022
…13923)

Missing media-queries and meta resources
caused PWA splash screen do not show up
on Apple devices.

Fixes: #13617
@vaadin-bot
Copy link
Collaborator

Hi @taefi and @mshabarov, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick e0c2c70
error: could not apply e0c2c70... fix: Add missing media-queries and resources for PWA splash screen (#13923)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

taefi added a commit that referenced this pull request Jun 10, 2022
mshabarov pushed a commit that referenced this pull request Jun 13, 2022
…13923) (#13947)

Missing media-queries and meta resources
caused PWA splash screen do not show up
on Apple devices.

Fixes: #13617

Co-authored-by: Soroosh Taefi <[email protected]>
taefi added a commit that referenced this pull request Jun 13, 2022
mshabarov pushed a commit that referenced this pull request Jun 13, 2022
…13923) (#13949)

Missing media-queries and meta resources
caused PWA splash screen do not show up
on Apple devices.

Fixes: #13617

Co-authored-by: Soroosh Taefi <[email protected]>
mshabarov pushed a commit that referenced this pull request Jun 13, 2022
…13923) (#13948)

Missing media-queries and meta resources
caused PWA splash screen do not show up
on Apple devices.

Fixes: #13617

Co-authored-by: Soroosh Taefi <[email protected]>
vaadin-bot pushed a commit that referenced this pull request Jun 13, 2022
mshabarov pushed a commit that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA - Splash screen not shown on iPhone 12
4 participants