Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add possibility to set header values for StreamResource #11860

Merged
merged 3 commits into from
Sep 16, 2021
Merged

fix: add possibility to set header values for StreamResource #11860

merged 3 commits into from
Sep 16, 2021

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Sep 15, 2021 •
edited
Loading

fixes #5471

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

caalador
caalador previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor javadoc change that would make it a bit clearer on a read

flow-server/src/main/java/com/vaadin/flow/server/StreamResource.java Outdated Show resolved Hide resolved
caalador
caalador previously approved these changes Sep 16, 2021
View reviewed changes
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  1. MINOR StreamResourceHandler.java#L71: Replace this lambda with a method reference. rule

@caalador caalador merged commit 508c0c4 into master Sep 16, 2021
@caalador caalador deleted the 5471-content-disposition-stream-resource branch September 16, 2021 08:38
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version.

mshabarov pushed a commit that referenced this pull request Jan 3, 2022
@mshabarov
fix: add possibility to set header values for StreamResource (#11860)
68fb43c 
fixes #5471

(cherry picked from commit 508c0c4)
mshabarov pushed a commit that referenced this pull request Jan 3, 2022
@mshabarov
fix: add possibility to set header values for StreamResource (#11860)
a62c0b9 
fixes #5471

(cherry picked from commit 508c0c4)
caalador pushed a commit that referenced this pull request Jan 3, 2022
@caalador
fix: add possibility to set header values for StreamResource (#11860)
f293031 
fixes #5471

(cherry picked from commit 508c0c4)
caalador pushed a commit that referenced this pull request Jan 3, 2022
@caalador
fix: add possibility to set header values for StreamResource (#11860)
ea9ca18 
fixes #5471

(cherry picked from commit 508c0c4)
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
prerelease version for platform 22.0.0 Released with Platform 14.8.2 Released with Platform 22.0.0.alpha4 +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StreamResource should have method for setting "Content-Disposition" response header
3 participants
@denis-anisimov @vaadin-bot @caalador