chore: update log message after versions.json separation #14083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
taefi
approved these changes
Jun 28, 2022
taefi
pushed a commit
that referenced
this pull request
Jun 28, 2022
(cherry picked from commit 1b86801)
taefi
pushed a commit
that referenced
this pull request
Jun 29, 2022
(cherry picked from commit 1b86801)
taefi
added a commit
that referenced
this pull request
Jun 29, 2022
* fix: separate core and commercial components version files (#14014) * fix: separate core and commercial components version files Fixes: #13749 Previously, the vaadin_versions.json contained both core and commercial components listed which led to including them all in package.json even if the user only used vaadin-core. Now platform generates vaadin-core-version.json in vaadin-core and vaadin-version.json to include commercial components in vaadin artifact. This commit will adopt having separate files while generating package.json and pinning the platform dependencies. (cherry picked from commit 23f5496) * test: add tests for handling separate versions in NodeUpdater (#14079) Tests are added for changes done in PR #14014 (cherry picked from commit 7140d32) * chore: update log message after versions.json separation (#14083) (cherry picked from commit 1b86801) Co-authored-by: Zhe Sun <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
* fix: separate core and commercial components version files (#14014) * fix: separate core and commercial components version files Fixes: #13749 Previously, the vaadin_versions.json contained both core and commercial components listed which led to including them all in package.json even if the user only used vaadin-core. Now platform generates vaadin-core-version.json in vaadin-core and vaadin-version.json to include commercial components in vaadin artifact. This commit will adopt having separate files while generating package.json and pinning the platform dependencies. (cherry picked from commit 23f5496) * test: add tests for handling separate versions in NodeUpdater (#14079) Tests are added for changes done in PR #14014 (cherry picked from commit 7140d32) * chore: update log message after versions.json separation (#14083) (cherry picked from commit 1b86801) Co-authored-by: Zhe Sun <[email protected]>
taefi
added a commit
that referenced
this pull request
Jul 1, 2022
…14104) * fix: separate core and commercial components version files (#14014) * fix: separate core and commercial components version files Fixes: #13749 Previously, the vaadin_versions.json contained both core and commercial components listed which led to including them all in package.json even if the user only used vaadin-core. Now platform generates vaadin-core-version.json in vaadin-core and vaadin-version.json to include commercial components in vaadin artifact. This commit will adopt having separate files while generating package.json and pinning the platform dependencies. (cherry picked from commit 23f5496) * test: add tests for handling separate versions in NodeUpdater (#14079) Tests are added for changes done in PR #14014 (cherry picked from commit 7140d32) * chore: update log message after versions.json separation (#14083) (cherry picked from commit 1b86801) Co-authored-by: Zhe Sun <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
taefi
added a commit
that referenced
this pull request
Jul 1, 2022
taefi
added a commit
that referenced
this pull request
Jul 1, 2022
taefi
added a commit
that referenced
this pull request
Jul 1, 2022
mcollovati
pushed a commit
that referenced
this pull request
Jul 1, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
mcollovati
pushed a commit
that referenced
this pull request
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #14014 fix, one log message needs to be updated.