Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proper handling of href when the anchor is disabled/enabled (#12616) (#12633) (CP: 2.7) #12639

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

) (#12633)

fixes #10924

# Conflicts:
#	flow-html-components/src/main/java/com/vaadin/flow/component/html/Anchor.java
#	flow-html-components/src/test/java/com/vaadin/flow/component/html/AnchorTest.java

Co-authored-by: Matti Tahvonen <[email protected]>
@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 3 issues

  1. MAJOR Anchor.java#L89: Remove this call from a constructor to the overridable "setHref" method. rule
  2. MAJOR Anchor.java#L90: Remove this call from a constructor to the overridable "setText" method. rule
  3. MAJOR Anchor.java#L91: Remove this call from a constructor to the overridable "setTarget" method. rule

@caalador caalador enabled auto-merge (squash) December 27, 2021 07:50
@caalador caalador merged commit a42c196 into 2.7 Dec 27, 2021
@caalador caalador deleted the cherry-pick-12633-to-2.7-1640589411132 branch December 27, 2021 08:06
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 14.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants