-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running devMode doesn't respect nodeVersion given in plugin configuration #12686
Comments
Isn't that how all configuration for dev mode works? The plugin configuration does not affect dev mode? If you run the |
So you are saying it's ok to not respect the defined version and use the default version? |
I am saying that the problems sounds like the same that #12498 is about, i.e. that you have to define all build related options in 2 places |
If it doesn't work when defining a system property, that sounds like a bug |
It is clearly a bug as there are multiple places that default to only using the default version instead of taking into account that they could be defined. |
Use node version and url properties if defined. Force home node also in plugin if set. part of #12686
Use node version and url properties if defined. Force home node also in plugin if set. part of #12686
If defined always use the node version and download root url is defined. Closes #12686
Use node version and url properties if defined. Force home node also in plugin if set. part of #12686
Use node version and url properties if defined. Force home node also in plugin if set. part of #12686
Use node version and url properties if defined. Force home node also in plugin if set. part of #12686 Co-authored-by: caalador <[email protected]>
If defined always use the node version and download root url is defined. Closes #12686
* fix: Always use defined node version If defined always use the node version and download root url is defined. Closes #12686
Description of the bug
Starting up a project with
requireHomeNodeExec
andnodeVersion
defined in for the plugin does install and use a node to~/.vaadin
, but does not use the defined nodeVersion instead using theDEFAULT_NODE_VERSION
Expected behavior
Defined version should be installed and not the default version
Minimal reproducible example
mvn
Versions
The text was updated successfully, but these errors were encountered: