Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running devMode doesn't respect nodeVersion given in plugin configuration #12686

Closed
caalador opened this issue Jan 10, 2022 · 5 comments · Fixed by #12695
Closed

Running devMode doesn't respect nodeVersion given in plugin configuration #12686

caalador opened this issue Jan 10, 2022 · 5 comments · Fixed by #12695

Comments

@caalador
Copy link
Contributor

Description of the bug

Starting up a project with requireHomeNodeExec and nodeVersion defined in for the plugin does install and use a node to ~/.vaadin, but does not use the defined nodeVersion instead using the DEFAULT_NODE_VERSION

Expected behavior

Defined version should be installed and not the default version

Minimal reproducible example

  • Define to any v14 demo to the maven plugin the configuration:
<configuration>
  <requireHomeNodeExec>true</requireHomeNodeExec>
  <nodeVersion>v17.2.0</nodeVersion>
</configuration>
  • Run mvn
  • See that the installed version is not 17.2.0, but the default 14.15.4

Versions

  • Vaadin / Flow version: 14+
@Artur-
Copy link
Member

Artur- commented Jan 10, 2022

Isn't that how all configuration for dev mode works? The plugin configuration does not affect dev mode? If you run the Application class in a Spring Boot project, you do not ever even run the plugin

@caalador
Copy link
Contributor Author

So you are saying it's ok to not respect the defined version and use the default version?
This doesn't at the moment work even if you define the version as a system property without the plugin.

@Artur-
Copy link
Member

Artur- commented Jan 10, 2022

I am saying that the problems sounds like the same that #12498 is about, i.e. that you have to define all build related options in 2 places

@Artur-
Copy link
Member

Artur- commented Jan 10, 2022

If it doesn't work when defining a system property, that sounds like a bug

@caalador
Copy link
Contributor Author

It is clearly a bug as there are multiple places that default to only using the default version instead of taking into account that they could be defined.

caalador added a commit that referenced this issue Jan 10, 2022
Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686
caalador added a commit that referenced this issue Jan 10, 2022
Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686
caalador added a commit that referenced this issue Jan 11, 2022
If defined always use the node version
and download root url is defined.

Closes #12686
@caalador caalador self-assigned this Jan 11, 2022
caalador added a commit that referenced this issue Jan 13, 2022
Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686
vaadin-bot pushed a commit that referenced this issue Jan 13, 2022
Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686
joheriks pushed a commit that referenced this issue Jan 13, 2022
Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686

Co-authored-by: caalador <[email protected]>
caalador added a commit that referenced this issue Jan 14, 2022
If defined always use the node version
and download root url is defined.

Closes #12686
joheriks pushed a commit that referenced this issue Jan 17, 2022
* fix: Always use defined node version

If defined always use the node version
and download root url is defined.

Closes #12686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants