Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always use defined node version #12689

Merged
merged 1 commit into from
Jan 13, 2022
Merged

fix: Always use defined node version #12689

merged 1 commit into from
Jan 13, 2022

Conversation

caalador
Copy link
Contributor

Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686

@joheriks joheriks self-requested a review January 10, 2022 12:03
@caalador
fix: use defined properties
c552170 
Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686
@caalador caalador force-pushed the issues/12686-use-parameters branch from d8b0cfa to c552170 Compare January 10, 2022 12:19
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 13 issues

  • CRITICAL 3 critical
  • MAJOR 9 major
  • MINOR 1 minor

Top 10 issues

  1. CRITICAL FlowModeAbstractMojo.java#L101: Move this variable to comply with Java Code Conventions. rule
  2. CRITICAL FlowModeAbstractMojo.java#L112: Move this variable to comply with Java Code Conventions. rule
  3. CRITICAL FlowModeAbstractMojo.java#L118: Move this variable to comply with Java Code Conventions. rule
  4. MAJOR DeploymentConfigurationFactory.java#L346: Remove this unused method parameter "contextClass". rule
  5. MAJOR DevModeHandler.java#L325: Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. rule
  6. MAJOR DevModeHandler.java#L472: Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. rule
  7. MAJOR DevModeHandler.java#L477: Invoke method(s) only conditionally. rule
  8. MAJOR DevModeHandler.java#L479: Invoke method(s) only conditionally. rule
  9. MAJOR DevModeHandler.java#L481: Invoke method(s) only conditionally. rule
  10. MAJOR DevModeHandler.java#L703: Invoke method(s) only conditionally. rule

@joheriks
Copy link
Contributor

LGTM. Perhaps update the first line of the commit message to indicate which property this is about (like in the the other PR)

@caalador caalador changed the title fix: use defined properties fix: Always use defined node version Jan 13, 2022
@caalador caalador merged commit ed0e7ee into 2.7 Jan 13, 2022
@caalador caalador deleted the issues/12686-use-parameters branch January 13, 2022 09:13
vaadin-bot pushed a commit that referenced this pull request Jan 13, 2022
@caalador @vaadin-bot
fix: Always use defined node version (#12689)
92964cf 
Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686
joheriks pushed a commit that referenced this pull request Jan 13, 2022
@vaadin-bot @caalador
fix: Always use defined node version (#12689) (#12717)
bbfd1b0 
Use node version and url properties if defined.
Force home node also in plugin if set.

part of #12686

Co-authored-by: caalador <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joheriks joheriks joheriks approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.8 Released with Platform 14.8.3 +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caalador @vaadin-bot @joheriks