Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read build parameters also from application.properties #12498

Open
Artur- opened this issue Dec 2, 2021 · 1 comment
Open

Read build parameters also from application.properties #12498

Artur- opened this issue Dec 2, 2021 · 1 comment

Comments

@Artur-
Copy link
Member

Artur- commented Dec 2, 2021

Description of the bug / feature

In a V22 Spring Boot project, you can define development mode to use npm instead of pnpm by adding

vaadin.pnpm.enable=false

to src/main/resources/application.properties

You can see on startup (mvn) that this works:

2021-12-02 14:40:11.413  INFO 26113 --- [onPool-worker-1] c.v.f.s.frontend.TaskUpdatePackages      : Running `npm install` to resolve and optionally download frontend dependencies. This may take a moment, please stand by...

However, when you do a production build as mvn package -Pproduction you can see that pnpm is used:

[INFO] Running `pnpm install` to resolve and optionally download frontend dependencies. This may take a moment, please stand by...

This is bad in many ways: unexpected, given lock file is not used, production doesn't match dev, ...

Expected behavior

The values you set in src/main/resources/application.properties would be used also for the production build.

@Artur- Artur- changed the title Read build parameters from application.properties Read build parameters also from application.properties Dec 2, 2021
@knoobie
Copy link
Contributor

knoobie commented Dec 2, 2021

The same rule should apply to the application.yml and yaml file for consistency.

Artur- added a commit that referenced this issue Dec 7, 2021
…if present

Reads "pnpm.enable", "require.home.node", "useDeprecatedV14Bootstrapping" and "eagerServerLoad" from application.properties. In the propertis file, all the keys must be prefixed with "vaadin."

Fixes #12498
Artur- added a commit that referenced this issue Dec 7, 2021
…if present

Reads "pnpm.enable", "require.home.node", "useDeprecatedV14Bootstrapping" and "eagerServerLoad" from application.properties. In the propertis file, all the keys must be prefixed with "vaadin."

Fixes #12498
Artur- added a commit that referenced this issue Dec 7, 2021
…if present

Reads "pnpm.enable", "require.home.node", "useDeprecatedV14Bootstrapping" and "eagerServerLoad" from application.properties. In the propertis file, all the keys must be prefixed with "vaadin."

Fixes #12498
Artur- added a commit that referenced this issue Dec 22, 2021
…if present

Reads "pnpm.enable", "require.home.node", "useDeprecatedV14Bootstrapping" and "eagerServerLoad" from application.properties. In the propertis file, all the keys must be prefixed with "vaadin."

Fixes #12498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants