Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove unnecessary shadow root helpers #12573

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 14, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

Unit Test Results

   717 files     717 suites   21m 12s ⏱️
5 618 tests 5 568 ✔️ 50 💤 0
5 631 runs  5 581 ✔️ 50 💤 0

Results for commit e760742.

♻️ This comment has been updated with latest results.

@Artur- Artur- force-pushed the remove-getinshadowroot branch from f8d5110 to f43ee46 Compare December 14, 2021 14:58
@Artur- Artur- requested a review from caalador December 14, 2021 14:58
@caalador caalador merged commit 30afed7 into master Dec 15, 2021
@caalador caalador deleted the remove-getinshadowroot branch December 15, 2021 09:09
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 8.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 30afed7
error: could not apply 30afed7... test: Remove unnecessary shadow root helpers (#12573)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

TC Format Checker Report - 10:01 - 16 - Dec

BLOCKER There are 3 files with format errors

  • To see a complete report of formatting issues, download the differences file

  • To fix the build, please run mvn formatter:format in your branch and commit the changes.

  • Optionally you might add the following line in your .git/hooks/pre-commit file:

    mvn formatter:format
    

Here is the list of files with format issues in your PR:

flow-tests/test-live-reload/src/test/java/com/vaadin/flow/uitest/ui/FrontendLiveReloadIT.java
flow-tests/test-live-reload/src/test/java/com/vaadin/flow/uitest/ui/JavaLiveReloadIT.java
flow-tests/test-live-reload/src/test/java/com/vaadin/flow/uitest/ui/PreserveOnRefreshLiveReloadIT.java

caalador pushed a commit that referenced this pull request Dec 20, 2021
ZheSun88 added a commit that referenced this pull request Dec 20, 2021
vaadin-bot added a commit that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants