Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use KeyMapper by default to generate unique keys #13883

Merged
merged 5 commits into from
Jun 7, 2022
Merged

fix: Use KeyMapper by default to generate unique keys #13883

merged 5 commits into from
Jun 7, 2022

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Jun 1, 2022 •
edited
Loading

Description

Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

mshabarov added 2 commits May 30, 2022 16:28
@mshabarov
fix: Use KeyMapper by default for unique keys
ba25cfc
@mshabarov
fix: Use KeyMapper by default to generate unique keys
0e28536 
Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156
@mshabarov mshabarov mentioned this pull request Jun 1, 2022
Merged
7 tasks
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

Unit Test Results

   972 files  ±0     972 suites  ±0   46m 14s ⏱️ - 3m 21s
6 304 tests +2  6 256 ✔️ +2  48 💤 ±0  0 ❌ ±0 
6 534 runs  +2  6 480 ✔️ +2  54 💤 ±0  0 ❌ ±0 

Results for commit 42248e8. ± Comparison against base commit 7affb83.

♻️ This comment has been updated with latest results.

@mshabarov mshabarov marked this pull request as ready for review June 2, 2022 14:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mshabarov mshabarov requested a review from taefi June 3, 2022 11:26
@taefi taefi merged commit 570244d into master Jun 7, 2022
@taefi taefi deleted the feature/keymapper branch June 7, 2022 10:39
@sissbruecker sissbruecker mentioned this pull request Jun 8, 2022
Merged
vaadin-bot pushed a commit that referenced this pull request Jun 8, 2022
@mshabarov @vaadin-bot
fix: Use KeyMapper by default to generate unique keys (#13883)
ae56099 
* fix: Use KeyMapper by default for unique keys

* fix: Use KeyMapper by default to generate unique keys

Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156
vaadin-bot pushed a commit that referenced this pull request Jun 8, 2022
@mshabarov @vaadin-bot
fix: Use KeyMapper by default to generate unique keys (#13883)
1fb15a2 
* fix: Use KeyMapper by default for unique keys

* fix: Use KeyMapper by default to generate unique keys

Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156
@vaadin-bot
Copy link
Collaborator

Hi @mshabarov and @taefi, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 570244d
error: could not apply 570244d... fix: Use KeyMapper by default to generate unique keys (#13883)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot pushed a commit that referenced this pull request Jun 8, 2022
@mshabarov @vaadin-bot
fix: Use KeyMapper by default to generate unique keys (#13883)
860cf5a 
* fix: Use KeyMapper by default for unique keys

* fix: Use KeyMapper by default to generate unique keys

Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156
@vaadin-bot
Copy link
Collaborator

Hi @mshabarov and @taefi, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 570244d
error: could not apply 570244d... fix: Use KeyMapper by default to generate unique keys (#13883)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @mshabarov and @taefi, when i performed cherry-pick to this commit to 1.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 570244d
error: could not apply 570244d... fix: Use KeyMapper by default to generate unique keys (#13883)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mshabarov added a commit that referenced this pull request Jun 10, 2022
@mshabarov
fix: Use KeyMapper by default to generate unique keys (#13883)
db65797 
* fix: Use KeyMapper by default for unique keys

* fix: Use KeyMapper by default to generate unique keys

Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156

(cherry picked from commit 570244d)
mshabarov pushed a commit that referenced this pull request Jun 10, 2022
@vaadin-bot
fix: Use KeyMapper by default to generate unique keys (#13883) (#13929)
3f53c52 
Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156
mshabarov added a commit that referenced this pull request Jun 10, 2022
@vaadin-bot @mshabarov
fix: Use KeyMapper by default to generate unique keys (#13883) (#13930)
a3103b0 
Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156

Co-authored-by: Mikhail Shabarov <[email protected]>
mshabarov pushed a commit that referenced this pull request Jun 10, 2022
@vaadin-bot
fix: Use KeyMapper by default to generate unique keys (#13883) (#13928)
357af12 
Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156
taefi pushed a commit that referenced this pull request Jun 10, 2022
@mshabarov @taefi
fix: Use KeyMapper by default to generate unique keys (#13883)
64e3aeb 
* fix: Use KeyMapper by default for unique keys

* fix: Use KeyMapper by default to generate unique keys

Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156

(cherry picked from commit 570244d)
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 14.8.13.

ZheSun88 pushed a commit that referenced this pull request Sep 21, 2022
@mshabarov @ZheSun88
fix: Use KeyMapper by default to generate unique keys (#13883)
1d09f19 
* fix: Use KeyMapper by default for unique keys

* fix: Use KeyMapper by default to generate unique keys

Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156

(cherry picked from commit 570244d)
mshabarov added a commit that referenced this pull request Sep 21, 2022
@ZheSun88 @mshabarov
fix: Use KeyMapper by default to generate unique keys (#13883) (#14596)
fb3a898 
Delegates to regular KeyMapper whenever the unique key provider is not present and a unique key is needed for a row.

Part-of: vaadin/flow-components#3156

(cherry picked from commit 570244d)

Co-authored-by: Mikhail Shabarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taefi taefi taefi approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.7 cherry-picked-2.8 cherry-picked-9.0 cherry-picked-23.0 cherry-picked-23.1 need to pick manually 1.0 Released with Vaadin 14.8.13 target/1.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshabarov @vaadin-bot @taefi @ZheSun88