test: DialogShortcutIT Wait for child element presence before performing assertions #12830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollovati
changed the title
…rom list
Sometimes findElements(By.tagNvame("div")) seems to return results
before server roundtrips are completed, so list of elements is missing
elements. Performing a direct searching for child element by xpath
(findElement(By.xpath("div[N]")))) seem always to work.
To be noted that xpath position is 1 based
Fixes #10481, #10487, #10491
mcollovati
force-pushed
the
issues/flaky_dialogshortcut_it
branch
from
e3975e3 to
52f51ec
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
joheriks
approved these changes
Jan 26, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
…ing assertions (#12830) Sometimes findElements(By.tagNvame("div")) seems to return results before server roundtrips are completed, so list of elements is missing elements. Performing a direct searching for child element by xpath (findElement(By.xpath("div[N]")))) seem always to work. To be noted that xpath position is 1 based Fixes #10481, #10487, #10491
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
…ing assertions (#12830) Sometimes findElements(By.tagNvame("div")) seems to return results before server roundtrips are completed, so list of elements is missing elements. Performing a direct searching for child element by xpath (findElement(By.xpath("div[N]")))) seem always to work. To be noted that xpath position is 1 based Fixes #10481, #10487, #10491
joheriks
pushed a commit
that referenced
this pull request
Jan 26, 2022
…ing assertions (#12830) Sometimes findElements(By.tagNvame("div")) seems to return results before server roundtrips are completed, so list of elements is missing elements. Performing a direct searching for child element by xpath (findElement(By.xpath("div[N]")))) seem always to work. To be noted that xpath position is 1 based Fixes #10481, #10487, #10491
joheriks
pushed a commit
that referenced
this pull request
Jan 26, 2022
…ing assertions (#12830) Sometimes findElements(By.tagNvame("div")) seems to return results before server roundtrips are completed, so list of elements is missing elements. Performing a direct searching for child element by xpath (findElement(By.xpath("div[N]")))) seem always to work. To be noted that xpath position is 1 based Fixes #10481, #10487, #10491
This was referenced Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes findElements(By.tagName("div")) returns an empty list, maybe because server roundtrip has not yet completed.
This change adds a wait condition to ensure the presence of the newly added element before doing assertions.
Fixes #10481
Fixes #10487
Fixes #10491
Type of change
Checklist
Additional for
Featuretype of change