Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not throw NPE for UI.access called when session has expired (#12531) (#12591) (CP: 2.7) #12596

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 3 issues

  1. MAJOR UI.java#L507: Reduce this anonymous class number of lines from 30 to at most 20, or make it a named class. rule
  2. MAJOR UI.java#L1044: Call "Optional#isPresent()" before accessing the value. rule
  3. MINOR UI.java#L1033: Remove the declaration of thrown exception 'java.lang.IllegalArgumentException' which is a runtime exception. rule

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 67aaf35 into 2.7 Dec 16, 2021
@vaadin-bot vaadin-bot deleted the cherry-pick-12591-to-2.7-1639660561724 branch December 16, 2021 14:11
@vaadin-bot
Copy link
Collaborator Author

This PR has been merged with 'squash' method.[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 14.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants