fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicator #13746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes vaadin#13745
mshabarov
changed the title
taefi
requested changes
May 19, 2022
...c/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalCommunicationController.java
Show resolved
Hide resolved
taefi
approved these changes
May 19, 2022
taefi
requested changes
May 19, 2022
...c/main/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalCommunicationController.java
Outdated
Show resolved
Hide resolved
taefi
approved these changes
May 19, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
May 19, 2022
…tor (#13746) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
May 19, 2022
…tor (#13746) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
May 19, 2022
…tor (#13746) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
May 19, 2022
…tor (#13746) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
May 19, 2022
…tor (#13746) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
mshabarov
added a commit
that referenced
this pull request
May 20, 2022
…tor (#13746) (#13814) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Pepijn Van Eeckhoudt <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
mshabarov
added a commit
that referenced
this pull request
May 20, 2022
…tor (#13746) (#13818) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Pepijn Van Eeckhoudt <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
mshabarov
added a commit
that referenced
this pull request
May 20, 2022
…tor (#13746) (#13815) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Pepijn Van Eeckhoudt <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
mshabarov
added a commit
that referenced
this pull request
May 20, 2022
…tor (#13746) (#13816) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Pepijn Van Eeckhoudt <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
mshabarov
added a commit
that referenced
this pull request
May 20, 2022
…tor (#13746) (#13817) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Pepijn Van Eeckhoudt <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this.
Fixes #13745
Type of change
Checklist
Additional for
Featuretype of change