fix: Avoid potential slow Set#removeAll call in HierarchicalCommunica…

…tor (#13746) * fix: Avoid potential slow Set#removeAll call in HierarchicalCommunicationController#passivateInactiveKeys The performance of calling Set#removeAll(List) is dependent on the relative sizes of the Set and List parameter. Replace Set#removeAll with List#forEach(Set::remove) to avoid this. Fixes #13745 Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
vaadin · May 19, 2022 · 9ca456d · 9ca456d
1 parent c3101ad
commit 9ca456d
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/...ain/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalCommunicationController.java b/...ain/java/com/vaadin/flow/data/provider/hierarchy/HierarchicalCommunicationController.java
@@ -287,7 +287,14 @@ private void passivateInactiveKeys(Set<String> oldActive,
             }
 
             // Finally clear any passivated items that have now been confirmed
-            oldActive.removeAll(newActiveKeyOrder);
+            /*
+             * Due to the implementation of AbstractSet#removeAll, if the size
+             * of newActiveKeyOrder is bigger than oldActive's size, then
+             * calling oldActive.removeAll(newActiveKeyOrder) would end up
+             * calling contains method for all of newActiveKeyOrder items which
+             * is a slow operation on lists. The following avoids that:
+             */
+            newActiveKeyOrder.forEach(oldActive::remove);
             if (!oldActive.isEmpty()) {
                 passivatedByUpdate.put(Integer.valueOf(updateId), oldActive);
             }