Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable ignored tests #12435

Merged
merged 1 commit into from
Nov 29, 2021
Merged

chore: enable ignored tests #12435

merged 1 commit into from
Nov 29, 2021

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Nov 24, 2021

No flakiness seen in 9 executions.
Re-enable tests for 2.8 and 2.7

Closes #10331

@caalador caalador marked this pull request as ready for review November 25, 2021 07:13
Copy link
Member

@Artur- Artur- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning on testing the flakyness somehow or just merge and see?

@caalador
Copy link
Contributor Author

I ran the tests 9 times without any failures and the ticket linked builds do not exist so there is no information on what the failure cause was.
So I would add them and see if they are still failing randomly for the 2.x branch which they don't seem to do.

@joheriks joheriks merged commit 928e11e into 2.8 Nov 29, 2021
@joheriks joheriks deleted the test/enable_tests branch November 29, 2021 12:08
vaadin-bot pushed a commit that referenced this pull request Nov 29, 2021
vaadin-bot added a commit that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants