Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate builder execution #12697

Merged
merged 5 commits into from
Jan 24, 2022

Conversation

caalador
Copy link
Contributor

The builder was executed twice, most
likely due to a merge conflict.

@caalador caalador force-pushed the issues/remove-duplicate-builder-exec branch 3 times, most recently from 0c48125 to 786db2b Compare January 12, 2022 11:10
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Jan 21, 2022
caalador and others added 4 commits January 21, 2022 15:06
The builder was executed twice, most
likely due to a merge conflict.
open instead of refresh
@caalador caalador force-pushed the issues/remove-duplicate-builder-exec branch from 555e075 to 132193e Compare January 21, 2022 13:06
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Jan 21, 2022
@caalador caalador requested a review from joheriks January 24, 2022 07:56
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  1. MAJOR DevModeInitializer.java#L425: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule

@caalador caalador requested a review from joheriks January 24, 2022 10:20
@joheriks joheriks merged commit 79ce222 into 2.8 Jan 24, 2022
@joheriks joheriks deleted the issues/remove-duplicate-builder-exec branch January 24, 2022 11:15
vaadin-bot pushed a commit that referenced this pull request Jan 24, 2022
The builder was executed twice, most
likely due to a merge conflict.
vaadin-bot added a commit that referenced this pull request Jan 24, 2022
The builder was executed twice, most
likely due to a merge conflict.

Co-authored-by: caalador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants