Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: --openssl-legacy-provider also in build-frontend (#12733) (CP: 2.7) #12757

Merged
merged 1 commit into from
Jan 19, 2022
Merged

fix: --openssl-legacy-provider also in build-frontend (#12733) (CP: 2.7) #12757

merged 1 commit into from
Jan 19, 2022

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 10 issues

  1. MAJOR DevModeHandler.java#L325: Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. rule
  2. MAJOR DevModeHandler.java#L472: Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. rule
  3. MAJOR DevModeHandler.java#L477: Invoke method(s) only conditionally. rule
  4. MAJOR DevModeHandler.java#L479: Invoke method(s) only conditionally. rule
  5. MAJOR DevModeHandler.java#L481: Invoke method(s) only conditionally. rule
  6. MAJOR DevModeHandler.java#L698: Invoke method(s) only conditionally. rule
  7. MAJOR DevModeHandler.java#L709: Either re-interrupt this method or rethrow the "InterruptedException". rule
  8. MAJOR FrontendTools.java#L561: A "NullPointerException" could be thrown; "output" is nullable here. rule
  9. MINOR BuildFrontendMojo.java#L203: Remove the declaration of thrown exception 'org.apache.maven.plugin.MojoExecutionException', as it cannot be thrown from method's body. rule
  10. MINOR FrontendTools.java#L553: Remove the declaration of thrown exception 'java.lang.IllegalStateException' which is a runtime exception. rule

@caalador caalador merged commit e78ac0b into 2.7 Jan 19, 2022
@caalador caalador deleted the cherry-pick-12733-to-2.7-1642511795326 branch January 19, 2022 05:43
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 14.8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
Released with Platform 14.8.3 +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaadin-bot @caalador