Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: close streams #12491

Merged
merged 6 commits into from
Dec 14, 2021
Merged

chore: close streams #12491

merged 6 commits into from
Dec 14, 2021

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Dec 2, 2021

touches #12489

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

Unit Test Results

   720 files     720 suites   21m 19s ⏱️
5 648 tests 5 598 ✔️ 50 💤 0
5 659 runs  5 609 ✔️ 50 💤 0

Results for commit b197b5c.

♻️ This comment has been updated with latest results.

Close stream in handle method that
documents that it also handles cleanup.
Artur-
Artur- previously approved these changes Dec 3, 2021
Artur-
Artur- previously approved these changes Dec 8, 2021
@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Dec 8, 2021
@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels Dec 8, 2021
@Artur-
Copy link
Member

Artur- commented Dec 9, 2021

CRITICAL StreamReceiverHandler.java#L29: Remove this unused import 'java.io.UncheckedIOException'. rule

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 5 issues

  1. MAJOR FeatureFlags.java#L1: Class com.vaadin.experimental.FeatureFlags defines non-transient non-serializable instance field lookup rule
  2. MAJOR FeatureFlags.java#L63: Make "lookup" transient or serializable. rule
  3. MAJOR FeatureFlags.java#L77: Remove this call from a constructor to the overridable "loadProperties" method. rule
  4. MAJOR FeatureFlags.java#L121: "context" is a method parameter, and should not be used for synchronization. rule
  5. MAJOR StreamReceiverHandler.java#L554: Method has 8 parameters, which is greater than 7 authorized. rule

@caalador caalador merged commit 62eeb17 into master Dec 14, 2021
@caalador caalador deleted the issues/close_opened_streams branch December 14, 2021 05:06
@vaadin-bot
Copy link
Collaborator

Hi @caalador and @caalador, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 62eeb17
error: could not apply 62eeb17... chore: close streams (#12491)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

Hi @caalador and @caalador, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 62eeb17
error: could not apply 62eeb17... chore: close streams (#12491)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants